Because of the decision taken for BZ11173, to write explicitly <br /> in notices when html format is used, BZ9372 that replaces carriage return with <br /> in html file is not necessary. It induces double <br /> fro each line.
Created attachment 28374 [details] [review] Bug 12294 : Cancel replacing carriage return with <br /> in printed html file as <br /> is needed in model for email notices when html format is checked
Test plan : * define an OVERDUE notice with html activated, with <br /> at each end of line * make sur you've got some borrowers with overdues meeting your notices triggering rules (some with valid email and others without) * run overdue_notices.pl -html to generate html files for borrowers without email Without patch * email notifications are correctly formated as html content, with one <br /> at each end of line * in html file, <br /> is duplicated at each end of line With patch * nothing changes for email notification * html file is correctly formatted with only one <br /> at each end of line
Created attachment 29151 [details] [review] [SIGNED-OFF] Bug 12294 : Cancel replacing carriage return on notices Cancel replacing carriage return with <br /> in printed html file as <br /> is needed in model for email notices when html format is checked Test plan : * define an OVERDUE notice with html activated, with <br /> at each end of line * make sur you've got some borrowers with overdues meeting your notices triggering rules (some with valid email and others without) * run overdue_notices.pl -html to generate html files for borrowers without email Without patch * email notifications are correctly formated as html content, with one <br /> at each end of line * in html file, <br /> is duplicated at each end of line With patch * nothing changes for email notification * html file is correctly formatted with only one <br /> at each end of line Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Copied test plan from comment. No errors
Created attachment 29652 [details] [review] [PASSED QA] Bug 12294 : Cancel replacing carriage return on notices Cancel replacing carriage return with <br /> in printed html file as <br /> is needed in model for email notices when html format is checked Test plan : * define an OVERDUE notice with html activated, with <br /> at each end of line * make sur you've got some borrowers with overdues meeting your notices triggering rules (some with valid email and others without) * run overdue_notices.pl -html to generate html files for borrowers without email Without patch * email notifications are correctly formated as html content, with one <br /> at each end of line * in html file, <br /> is duplicated at each end of line With patch * nothing changes for email notification * html file is correctly formatted with only one <br /> at each end of line Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Copied test plan from comment. No errors Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
My only concern with this patch is the fact that libraries have taken into account this bug when crafting notices. However, given that this is a whitespace issue, I think a release note would be adequate.
Patch pushed to master. Thanks Sophie! Note: I'll add a reference to this in the release notes as Kyle proposed.