Description
Kyle M Hall (khall)
2014-05-22 10:36:46 UTC
Created attachment 28420 [details] [review] Bug 12307 - Catalog details page displaying incorrect status for items with itemtype level notforloan status The template markup that controls that status column for the items table in catalogue/detail.pl does not account for the itemtypes.notforloan flag. Test Plan: 1) Find an item that is currently available 2) Go to the itemtype editor and mark that itemtype of that item as being not for loan 3) Browse to the catalog details page for that item's record 4) Note the item status is still "Available" 5) Apply this patch 6) Reload the catalog details page 7) Note the item status is now "Not for loan" This looks similar than bug 12419 (but not the same view). We didn't understand the bug to be fixed, we could not manage to see the bug on the master version in english, we give up. The bug should be explained with more details. (In reply to Koha Team Lyon 3 from comment #3) > We didn't understand the bug to be fixed, we could not manage to see the bug > on the master version in english, we give up. The bug should be explained > with more details. See with Lyon 3, the item-level_itypes pref should be set to "item specific". They use "biblio record", so they won't test this patch. But no regression found for biblio level :) Created attachment 29491 [details] [review] [SIGNED OFF] Bug 12307 - Catalog details page displaying incorrect status for items with itemtype level notforloan status The template markup that controls that status column for the items table in catalogue/detail.pl does not account for the itemtypes.notforloan flag. Test Plan: 1) Find an item that is currently available 2) Go to the itemtype editor and mark that itemtype of that item as being not for loan 3) Browse to the catalog details page for that item's record 4) Note the item status is still "Available" 5) Apply this patch 6) Reload the catalog details page 7) Note the item status is now "Not for loan" Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Created attachment 29527 [details] [review] [PASSED QA] Bug 12307 - Catalog details page displaying incorrect status for items with itemtype level notforloan status The template markup that controls that status column for the items table in catalogue/detail.pl does not account for the itemtypes.notforloan flag. Test Plan: 1) Find an item that is currently available 2) Go to the itemtype editor and mark that itemtype of that item as being not for loan 3) Browse to the catalog details page for that item's record 4) Note the item status is still "Available" 5) Apply this patch 6) Reload the catalog details page 7) Note the item status is now "Not for loan" Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Good catch! Works as described, no problems found. Patch pushed to master. Thanks Brendan! |