|
Description
paxed
2014-06-03 04:30:47 UTC
I've started working on this bug. Justin Vos I'm not sure what is required here. While editing a patron's details in the staff client, there is already a link back to the patron's details page in the left side-bar named "Details". Is the link needed somewhere else? Hi Justin, try the following: - go to the patron account from the OPAC - enter an address change request from the details page there - see that a note appears in the patron module and on the start page of the staff client - the entry asking to moderate the modification is the one to change Created attachment 40053 [details] [review] Bug 12352: Patron modification request page: Add link to patron record The patron modification request page in the staff client does show the name and home library of a patron, but there is no way to go to the patron record. This patch adds a link to the patron details. Extras: changes display of patron name, so a missing firstname won't result in an extra , showing. To test: - Make some update requests from different patron accounts in the OPAC - Go to the patron modification request page in staff - Verify a link 'Patron details' now shows on each entry and works correctly Created attachment 40059 [details] [review] [Signed-off] Bug 12352: Patron modification request page: Add link to patron record The patron modification request page in the staff client does show the name and home library of a patron, but there is no way to go to the patron record. This patch adds a link to the patron details. Extras: changes display of patron name, so a missing firstname won't result in an extra , showing. To test: - Make some update requests from different patron accounts in the OPAC - Go to the patron modification request page in staff - Verify a link 'Patron details' now shows on each entry and works correctly Followed test plan. Works as expected. QA tools OK. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 40191 [details] [review] Bug 12352: Patron modification request page: Add link to patron record The patron modification request page in the staff client does show the name and home library of a patron, but there is no way to go to the patron record. This patch adds a link to the patron details. Extras: changes display of patron name, so a missing firstname won't result in an extra , showing. To test: - Make some update requests from different patron accounts in the OPAC - Go to the patron modification request page in staff - Verify a link 'Patron details' now shows on each entry and works correctly Followed test plan. Works as expected. QA tools OK. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Not sure the "Patron details" link is at the best place, but I don't have something better to suggest. Agreed - but as the name in the tab is already a link for the 'accordeon' effect, there was no other obvious spot I could think of. Patch pushed to master. Thanks Katrina! |