When OPACPatronDetails is set to Allow in a multi-library environment, it is sometimes useful if the library of the user submitting the change is visible to the staff member approving the change, so that each library can approve or deny the request from their own patrons. The attached patch corrects that. To test: Ensure OPACPatronDetails is set to enabled Apply the patch Log into the OPAC and update your patron details (address, phone number etc) Log into the staff client and view pending patron changes. The branchcode of the library to which the patron belongs should display next to the user's name.
Created attachment 33958 [details] [review] Allow patron's library to display after patron updates details
Traceback (most recent call last): File "/usr/local/bin/git-bz", line 2630, in <module> do_apply(*args) File "/usr/local/bin/git-bz", line 1755, in do_apply users = bug.server.get_xmlrpc_proxy().User.get({ 'names': [patch.attacher] })['users'] File "/usr/lib/python2.6/xmlrpclib.py", line 1199, in __call__ return self.__send(self.__name, args) File "/usr/lib/python2.6/xmlrpclib.py", line 1489, in __request verbose=self.__verbose File "/usr/lib/python2.6/xmlrpclib.py", line 1243, in request headers xmlrpclib.ProtocolError: <ProtocolError for bugs.koha-community.org/xmlrpc.cgi: 404 Not Found> Not sure if this is a problem on my end or what. Christopher
I get the same problem. It looks like the patch isn't formatted correctly? Please resubmit the patch, and while you're at it, add a description of the bug and a test plan.
Created attachment 34074 [details] [review] Version 2 of the patch Sorry, I don't know why the patch wouldn't apply - I've tried to regenerate it so hopefully it will work OK this time. To test: 1) Ensure OPACPatronDetails is set to enabled 2) Log into the OPAC and update your patron details (address, phone number etc) 3) Log into the staff client and view pending patron changes. The branchcode of the library to which the patron belongs will not display. 4) Apply the patch 5) Log into the staff client again and view pending patron changes. The branchcode of the library to which the patron belongs should now display next to the user's name.
I've tested this patch against a sandbox and it compiles OK. There is already a description of the enhancement in comment 1.
Your second patch applied successfully using git-bz. Thanks for resubmitting.
Created attachment 34162 [details] [review] [Signed-off] Bug 13349 - Allow library code to display against users pending changes -update screen http://bugs.koha-community.org/show_bug.cgi?id=13349 To test: Ensure OPACPatronDetails is set to enabled Apply the patch Log into the OPAC and update your patron details (address, phone number etc) Log into the staff client and view pending patron changes. The branchcode of the library to which the patron belongs should display next to the user's name. Followed test plan, works as expected Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 34349 [details] [review] [PASSED QA] Bug 13349 - Allow library code to display against users pending changes -update screen http://bugs.koha-community.org/show_bug.cgi?id=13349 To test: Ensure OPACPatronDetails is set to enabled Apply the patch Log into the OPAC and update your patron details (address, phone number etc) Log into the staff client and view pending patron changes. The branchcode of the library to which the patron belongs should display next to the user's name. Followed test plan, works as expected Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 34350 [details] [review] [PASSED QA] Bug 13349 [QA Followup] I don't think we need the library label. Also switched to displaying the library name, rather than just the branchcode. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Patches pushed to master. Thanks David!