Bug 12419

Summary: Not for loan items are not listed
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: CatalogingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: gmcharlt, m.de.rooy, marjorie.barry-vila, tomascohen
Version: Main   
Hardware: All   
OS: All   
See Also: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12307
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 12419: Not for loan items are not listed
[SIGNED-OFF] Bug 12419: Not for loan items are not listed
[PASSED QA] Bug 12419: Not for loan items are not listed
Bug 12419: (QA followup) regression tests
Bug 12419: (QA followup) regression tests

Description Jonathan Druart 2014-06-13 13:27:35 UTC
On the cataloguing search (cataloguing/addbook.pl), if an item has a notforloan value > 0, the item is not listed in the Location column.

It is quite confusing, the current behavior let patrons believe that there is not item for the biblio (or less than the real count).
Comment 1 Jonathan Druart 2014-06-13 13:30:56 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2014-06-13 13:31:36 UTC
I'am not sure at all that is the best way to fix this issue. Ideas welcomed.
Comment 3 Nicole C. Engard 2014-06-18 20:22:20 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2014-06-21 16:40:12 UTC
Created attachment 29135 [details] [review]
[PASSED QA] Bug 12419: Not for loan items are not listed

On the cataloguing search (cataloguing/addbook.pl), if an item has a
notforloan value > 0, the item is not listed in the Location column.

It is quite confusing, the current behavior let patrons believe that
there is not item for the biblio (or less than the real count).

Test plan:
1/ Create 2 biblio records A and B
2/ Create some items for A
3/ Create 1+ item(s) for B with a notforloan status > 0
4/ Reindex both records
5/ Launch a search on the cataloguing module and verify that the
notforloan items are not listed in the 'Location' column.
6/ Apply this patch and verify the not for loan items are listed ("Not
for loan (XXX)").

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes tests and QA script, not for loan items now show up.
Comment 5 Tomás Cohen Arazi (tcohen) 2014-06-30 18:48:20 UTC Comment hidden (obsolete)
Comment 6 Tomás Cohen Arazi (tcohen) 2014-06-30 18:56:42 UTC
Created attachment 29385 [details] [review]
Bug 12419: (QA followup) regression tests

Changes to searchResults deserve unit tests.

Edit: minor tweaks:
 - Remove warning in line 702
 - Modernize
 - License added
 - "This file is a stub" removed

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Comment 7 Tomás Cohen Arazi (tcohen) 2014-06-30 18:58:59 UTC
Patch pushed to master.

Thanks Jonathan!
Comment 8 Galen Charlton 2014-09-23 20:46:06 UTC
Pushed to 3.16.x for inclusion in 3.16.4.