Created attachment 31166 [details]
020$z
Created attachment 31167 [details] [review] Bug 12829: (MARC21) properly skip 020z when rendering ISBN for normal record display Currently, 020$z oocurences are not shown, but the XSLT logic used is introducing punctuation characters for those $z occurences. This patch adds a check for the existence of subfield a, and skips otherwise. To test: - Create/have a record with 020$z (one or more) but no 020$a. - Open the detail page for the record (on both OPAC and staff). => FAIL: the ISBN label and ';' and '.' characters incorrectly shown. - Repeat mixing with 020$a occurences to notice the bug. - Apply the patch, reload => SUCCES: ISBN label shows only on the presence of a 020$a, and 020$z are skipped. - Sign off :-D Regards To+ Created attachment 31168 [details] [review] Bug 12829: (NORMARC) properly skip 020z when rendering ISBN for normal record display Currently, 020$z oocurences are not shown, but the XSLT logic used is introducing punctuation characters for those $z occurences. This patch adds a check for the existence of subfield a, and skips otherwise. To test: - Create/have a record with 020$z (one or more) but no 020$a. - Open the detail page for the record (on both OPAC and staff). => FAIL: the ISBN label and ';' and '.' characters incorrectly shown. - Repeat mixing with 020$a occurences to notice the bug. - Apply the patch, reload => SUCCES: ISBN label shows only on the presence of a 020$a, and 020$z are skipped. - Sign off :-D Regards To+ Created attachment 31182 [details] [review] [SIGNED-OFF] Bug 12829: (MARC21) properly skip 020z when rendering ISBN for normal record display Currently, 020$z oocurences are not shown, but the XSLT logic used is introducing punctuation characters for those $z occurences. This patch adds a check for the existence of subfield a, and skips otherwise. To test: - Create/have a record with 020$z (one or more) but no 020$a. - Open the detail page for the record (on both OPAC and staff). => FAIL: the ISBN label and ';' and '.' characters incorrectly shown. - Repeat mixing with 020$a occurences to notice the bug. - Apply the patch, reload => SUCCES: ISBN label shows only on the presence of a 020$a, and 020$z are skipped. - Sign off :-D Regards To+ Signed-off-by: Owen Leonard <oleonard@myacpl.org> I am still getting a ";" if a field with 020$a is followed by a field with 020$z Adding another field with 020$a does not add a doubled semicolon, and neither does a second 020$z Please see "my" Bug 11653 - For tag "020" only subfields "a" is displayed in MARC XSLT OPAC's detail template Created attachment 32936 [details] [review] Bug 12829: properly skip invalid ISBN when rendering for normal record display Currently, 020$z (and 010$z fr UNIMARC) occurences are not shown, but the XSLT logic used introduces punctuation characters for those $z occurences. This patch adds a check for the existence of subfield a, and only loops on $a subfields. To test: - Create/have a record with 020$z (or 010$z on UNIMARC) but no 020$a (no 010$a on UNIMARC). - Open the detail page for the record (on both OPAC and staff). => FAIL: the ISBN label and ';' and '.' characters incorrectly shown. - Repeat mixing with 020$a occurences to notice the bug. - Apply the patch, reload => SUCCES: ISBN label shows only on the presence of a $a, and $z are skipped. no matter how many ISBN fields you add. - Sign off :-D Regards To+ http://bugs.koha-community.org/show_bug.cgi?id=12901 Created attachment 32938 [details] [review] [SIGNED-OFF] Bug 12829: properly skip invalid ISBN when rendering for normal record display Currently, 020$z (and 010$z fr UNIMARC) occurences are not shown, but the XSLT logic used introduces punctuation characters for those $z occurences. This patch adds a check for the existence of subfield a, and only loops on $a subfields. To test: - Create/have a record with 020$z (or 010$z on UNIMARC) but no 020$a (no 010$a on UNIMARC). - Open the detail page for the record (on both OPAC and staff). => FAIL: the ISBN label and ';' and '.' characters incorrectly shown. - Repeat mixing with 020$a occurences to notice the bug. - Apply the patch, reload => SUCCES: ISBN label shows only on the presence of a $a, and $z are skipped. no matter how many ISBN fields you add. - Sign off :-D Regards To+ http://bugs.koha-community.org/show_bug.cgi?id=12901 Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Created attachment 33273 [details] [review] [PASSED QA] Bug 12829: properly skip invalid ISBN when rendering for normal record display Currently, 020$z (and 010$z fr UNIMARC) occurences are not shown, but the XSLT logic used introduces punctuation characters for those $z occurences. This patch adds a check for the existence of subfield a, and only loops on $a subfields. To test: - Create/have a record with 020$z (or 010$z on UNIMARC) but no 020$a (no 010$a on UNIMARC). - Open the detail page for the record (on both OPAC and staff). => FAIL: the ISBN label and ';' and '.' characters incorrectly shown. - Repeat mixing with 020$a occurences to notice the bug. - Apply the patch, reload => SUCCES: ISBN label shows only on the presence of a $a, and $z are skipped. no matter how many ISBN fields you add. - Sign off :-D Regards To+ http://bugs.koha-community.org/show_bug.cgi?id=12901 Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 33274 [details] [review] Bug 12829: Follow-up - fix small display issue in UNIMARC UNIMARC XSLT uses <li> instead of <span>. Patches pushed to master. |
Created attachment 31165 [details] isbn label The 020$z doesn't display - and shouldn't, but it does show the label for the ISBN field if there is an 020$z. The label should only appear if there is an 020$a.