Bug 13164 - Incorrect ISSN visualization on the normal view if invalid/cancelled ISSN present
Summary: Incorrect ISSN visualization on the normal view if invalid/cancelled ISSN pre...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-29 19:03 UTC by Tomás Cohen Arazi
Modified: 2015-06-04 23:32 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 13164: Incorrect ISSN visualization on the normal view if invalid/cancelled ISSN present (10.71 KB, patch)
2014-10-29 19:35 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 13164: Incorrect ISSN visualization on the normal view if invalid/cancelled ISSN present (10.84 KB, patch)
2014-10-30 07:48 UTC, Frédéric Demians
Details | Diff | Splinter Review
[PASSED QA] Bug 13164: Incorrect ISSN visualization on the normal view if invalid/cancelled ISSN present (10.90 KB, patch)
2014-10-31 15:32 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2014-10-29 19:03:54 UTC
Currently, 022$z (and 011$z for UNIMARC) occurences are not shown, but the XSLT logic used introduces punctuation characters for those $z occurences.
Comment 1 Tomás Cohen Arazi 2014-10-29 19:35:50 UTC Comment hidden (obsolete)
Comment 2 Frédéric Demians 2014-10-30 07:48:18 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2014-10-31 15:32:22 UTC
Created attachment 33083 [details] [review]
[PASSED QA] Bug 13164: Incorrect ISSN visualization on the normal view if invalid/cancelled ISSN present

Currently, 022$z (and 011$z for UNIMARC) occurences are not shown, but the XSLT
logic used introduces punctuation characters for those $z occurences.

This patch adds a check for the existence of subfield a, and only loops
on $a subfields.

To test:
- Create/have a record with 022$z (or 011$z on UNIMARC) but no 022$a (no 011$a on UNIMARC).
- Open the detail page for the record (on both OPAC and staff).
=> FAIL: the ISSN label and ';' and '.' characters incorrectly shown.
- Repeat mixing with 022$a occurences to notice the bug.
- Apply the patch, reload
=> SUCCES: ISSN label shows only on the presence of a $a, and $z are skipped.
           no matter how many ISSN fields you add.
- Sign off :-D

Regards
To+

Signed-off-by: Frederic Demians <f.demians@tamil.fr>

Works as described on an UNIMARC DB. Mimics what's done for ISBN field.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Tomás Cohen Arazi 2014-10-31 17:56:10 UTC
Patch pushed to master.