Description
Marc Véron
2014-09-07 15:25:13 UTC
Maybe we could use 'Selected' on the z39.50 configuration? I would prefer "Search by default" in form for new targets and "Default search" as column heading. Hm I think we need a native speaker to resolve :) Created attachment 31437 [details] [review] Bug 12882 - Translations: Resolve ambiguity for word "checked" This patch resolves the ambiguity of the word "Checked" for Z39.50 server administration. To test: Apply patch In staff client, go to Home:Administration:Z39.50/SRU servers Result: Column heading of 6th column should show "Default search" (instead of "Checked") Edit or create new server for Z39.50 and SRU Result: Checkbox underneath "Password" should have label "Search by default:" Click "Help" at top right of screen Result: Wording changed for selecting targets as default. Note: Changing the word "Checked" in suggestions management would be much more complicated. That's why I restricted this patch on Z39.50 server administration to have a fast solution for wrong translations in this module. I would personally opt for "Select by default" rather than "Search by default". Search by default may be more confusing. Another note: We still miss the signoff line from aleisha. (In reply to M. de Rooy from comment #6) > I would personally opt for "Select by default" rather than "Search by > default". > Search by default may be more confusing. I asked for input on IRC channel: http://irc.koha-community.org/koha/2014-09-09#i_1564999 Snippets: oleonard: "Active" as the table header and "Active (searched by default)" in the add/edit form cait: maybe selected? we use that for the checkboxes in tables select all / unselect gerundio: enabled? oleonard: Enabled is good, for Z39.50 admin. cait: i wonder if people will think it's to turn on/off the search option totally mveron: Preselect for z39.50 admin? cait: oh preselect is also nice Note: Current patch has Table header: Default search Form: Search by default (In reply to Marc Véron from comment #8) > mveron: Preselect for z39.50 admin? > cait: oh preselect is also nice That sounds even better. Why not Preselect? Note btw that changing strings because of translation limitations is imo not really ideal. It is a workaround; we probably should make changes to the translation process, which is of course much harder.. (In reply to M. de Rooy from comment #9) > > Note btw that changing strings because of translation limitations is imo not > really ideal. It is a workaround; we probably should make changes to the > translation process, which is of course much harder.. msgctxt I copy M. de Rooy's comment about translating and paxed's hint for msgctxt () www.gnu.org/software/gettext/manual/html_node/Contexts.htmlto Bug 11285 because 11285 is a more generic bug regarding ambiguities and translations. msgctxt sounds interesting. Created attachment 31503 [details] [review] Bug 12882 - Translations: Resolve ambiguity for word "checked" in Z39.50 server administration This patch resolves the ambiguity of the word "Checked" for Z39.50 server administration. To test: Apply patch In staff client, go to Home:Administration:Z39.50/SRU servers Result: Column heading of 6th column should show "Preselected" (instead of "Checked") Edit or create new server for Z39.50 and SRU Result: Checkbox underneath "Password" should have label "Preselected (searched by default):" Click "Help" at top right of screen Result: Wording changed for selecting targets as default. New patch with "Preselected", changed back to 'Needs Signoff' Created attachment 31506 [details] [review] [SIGNED-OFF] Bug 12882 - Translations: Resolve ambiguity for word "checked" in Z39.50 server administration This patch resolves the ambiguity of the word "Checked" for Z39.50 server administration. To test: Apply patch In staff client, go to Home:Administration:Z39.50/SRU servers Result: Column heading of 6th column should show "Preselected" (instead of "Checked") Edit or create new server for Z39.50 and SRU Result: Checkbox underneath "Password" should have label "Preselected (searched by default):" Click "Help" at top right of screen Result: Wording changed for selecting targets as default. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 31510 [details] [review] Bug 12882 - Translations: Resolve ambiguity for word "checked" in Z39.50 server administration This patch resolves the ambiguity of the word "Checked" for Z39.50 server administration. To test: Apply patch In staff client, go to Home:Administration:Z39.50/SRU servers Result: Column heading of 6th column should show "Preselected" (instead of "Checked") Edit or create new server for Z39.50 and SRU Result: Checkbox underneath "Password" should have label "Preselected (searched by default):" Click "Help" at top right of screen Result: Wording changed for selecting targets as default. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Patch pushed to master. Thanks Marc! |