Bug 12915

Summary: Convert checkouts table to ajax datatable [3.16.x], AllowRenewalLimitOverride crashes datatable
Product: Koha Reporter: Olli-Antti Kivilahti <olli-antti.kivilahti>
Component: CirculationAssignee: Olli-Antti Kivilahti <olli-antti.kivilahti>
Status: RESOLVED DUPLICATE QA Contact: Testopia <testopia>
Severity: critical    
Priority: P1 - high CC: abl, gmcharlt, kyle.m.hall, kyle, veron
Version: unspecified   
Hardware: All   
OS: All   
See Also: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12878
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12811
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 11703    
Bug Blocks:    
Attachments: hotfix to this permission non-testing issue!
hotfix to this permission non-testing issue!
[Signed-off] Bug 12915 - Convert checkouts table to ajax datatable [3.16.x], AllowRenewalLimitOverride crashes datatable

Description Olli-Antti Kivilahti 2014-09-13 07:52:21 UTC Comment hidden (obsolete)
Comment 1 Olli-Antti Kivilahti 2014-09-13 07:53:29 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2014-09-13 12:41:39 UTC
Created attachment 31575 [details] [review]
[Signed-off] Bug 12915 - Convert checkouts table to ajax datatable [3.16.x], AllowRenewalLimitOverride crashes datatable

when user doesn't have the permission.

TO REPLICATE::

load circ/circulate.pl with a user with only the following permissions:
       circulate_remaining_permissions
       catalogue

observe checkouts and holds not loading. Actually this crashes all javascript on the page!

Reproduced bug without patch. Applied patch, page displays as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Comment 3 Jacek Ablewicz 2014-09-13 20:31:23 UTC
There is another similar issue in members/moremember.tt template (I'm not 100% sure it does affect 3.16.x branch as well - it most likely does, but I only eyeballed 3.16.x code to confirm this, without doing any actual tests in that branch).
Comment 4 Katrin Fischer 2014-09-14 19:35:52 UTC
I think this is almost a duplicate to bug 12878, but solving it differently. Kyle, could you take a look please?
Comment 5 Kyle M Hall (khall) 2014-09-15 11:02:25 UTC

*** This bug has been marked as a duplicate of bug 12878 ***
Comment 6 Kyle M Hall (khall) 2014-09-15 11:03:06 UTC
(In reply to Katrin Fischer from comment #4)
> I think this is almost a duplicate to bug 12878, but solving it differently.
> Kyle, could you take a look please?

It is a duplicate. This patch only fixes circulation.pl while the other patch fixes both circulation.pl and moremember.pl.

Kyle
Comment 7 Kyle M Hall (khall) 2014-09-15 11:04:04 UTC
Furthermore, I know there is a third duplicate on bugzilla somewhere that is also signed off. It will probably be the one to make it into master.
Comment 8 Katrin Fischer 2014-09-15 11:19:13 UTC
Any chance to clear up that mess a bit? :)
Comment 9 Olli-Antti Kivilahti 2014-09-15 12:42:34 UTC
Don't push this push the other one.
Clear enough?
Comment 10 Katrin Fischer 2014-09-15 12:56:30 UTC
Ok, it appears we have 3 patches for this - bug 12811 (pqa), bug 12920 and bug 12915) - and are probably going with 12811 plus follow-up.
Comment 11 Jacek Ablewicz 2014-09-15 13:42:40 UTC
Hmm, Bug 12915 seems to be not an exact duplicate (triplicate? ;) for Bug 12811 / Bug 12878; it has some additional good stuff in it, which is not included in 12811 nor in the followup in Bug 12920 (= fix for missing semicolon in koha-tmpl/intranet-tmpl/prog/en/includes/strings.inc). Could we get strings.inc fix moved somewhere else (maybe to the separate bug report, if that would not be too much trouble ?) - I allready tested this fix, but after 12915 got marked as duplicate, there is no longer any place to sign it off..
Comment 12 Katrin Fischer 2014-09-15 14:06:15 UTC
Hi Jacek - thx for noticing :) Could you file a separate bug maybe? and link it to bug 12811 and the one we want to take the fix from?