Bug 12878 - Not having the permission circulate_override_renewals triggers error that prevents checkouts table from loading
Summary: Not having the permission circulate_override_renewals triggers error that pre...
Status: RESOLVED DUPLICATE of bug 12811
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low major
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
: 12915 (view as bug list)
Depends on: 11703
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-05 15:21 UTC by Kyle M Hall (khall)
Modified: 2014-09-15 11:02 UTC (History)
4 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 12878 - Not having the permission circulate_override_renewals triggers error that prevents checkouts table from loading (1.74 KB, patch)
2014-09-05 15:49 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 12878 - Not having the permission circulate_override_renewals triggers error that prevents checkouts table from loading (2.62 KB, patch)
2014-09-05 16:00 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall (khall) 2014-09-05 15:21:10 UTC
Not having the override_renewals permission will trigger the following error on circulation.pl:

Uncaught SyntaxError: Unexpected token ;

This prevents the rest of the javascript on the page from executing, including but not limited to the loading of the checkouts table.
Comment 1 Kyle M Hall (khall) 2014-09-05 15:32:31 UTC
Patch will be forthcoming. I believe this affects master and 3.16.03.
Comment 2 Kyle M Hall (khall) 2014-09-05 15:49:21 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall (khall) 2014-09-05 16:00:16 UTC
Created attachment 31417 [details] [review]
Bug 12878 - Not having the permission circulate_override_renewals triggers error that prevents checkouts table from loading

Not having the override_renewals permission will trigger the following
error on circulation.pl:

Uncaught SyntaxError: Unexpected token ;

This prevents the rest of the javascript on the page from executing,
including but not limited to the loading of the checkouts table.

Test Plan:
1) Using an account without the override renewals permission, start
   to check out items to a patron.
2) Note the checkouts table is broken
3) Apply this patch
4) Reload the page
5) Note the checkouts table is now working
Comment 4 Jacek Ablewicz 2014-09-06 08:55:51 UTC

*** This bug has been marked as a duplicate of bug 12811 ***
Comment 5 Olli-Antti Kivilahti 2014-09-15 08:00:28 UTC
I would like for you to mark these bugs as dependencies or even somehow related to existing features so one can easily find them.
For ex Bug 11703 for this bug, so I don't have to do Bug 12915.

BTW, Kyles solution is better, + I would prefer someone includes the translation file issue in my patch.
Comment 6 Kyle M Hall (khall) 2014-09-15 11:02:25 UTC
*** Bug 12915 has been marked as a duplicate of this bug. ***