Not having the override_renewals permission will trigger the following error on circulation.pl: Uncaught SyntaxError: Unexpected token ; This prevents the rest of the javascript on the page from executing, including but not limited to the loading of the checkouts table.
Patch will be forthcoming. I believe this affects master and 3.16.03.
Created attachment 31416 [details] [review] Bug 12878 - Not having the permission circulate_override_renewals triggers error that prevents checkouts table from loading Not having the override_renewals permission will trigger the following error on circulation.pl: Uncaught SyntaxError: Unexpected token ; This prevents the rest of the javascript on the page from executing, including but not limited to the loading of the checkouts table. Test Plan: 1) Using an account without the override renewals permission, start to check out items to a patron. 2) Note the checkouts table is broken 3) Apply this patch 4) Reload the page 5) Note the checkouts table is now working
Created attachment 31417 [details] [review] Bug 12878 - Not having the permission circulate_override_renewals triggers error that prevents checkouts table from loading Not having the override_renewals permission will trigger the following error on circulation.pl: Uncaught SyntaxError: Unexpected token ; This prevents the rest of the javascript on the page from executing, including but not limited to the loading of the checkouts table. Test Plan: 1) Using an account without the override renewals permission, start to check out items to a patron. 2) Note the checkouts table is broken 3) Apply this patch 4) Reload the page 5) Note the checkouts table is now working
*** This bug has been marked as a duplicate of bug 12811 ***
I would like for you to mark these bugs as dependencies or even somehow related to existing features so one can easily find them. For ex Bug 11703 for this bug, so I don't have to do Bug 12915. BTW, Kyles solution is better, + I would prefer someone includes the translation file issue in my patch.
*** Bug 12915 has been marked as a duplicate of this bug. ***