|
Description
Jonathan Druart
2014-11-03 16:26:28 UTC
Created attachment 33166 [details] [review] Bug 13190: Reintroduce the checkouts export feature Bug 11703 breaks the checkouts export feature. To reproduce: Fill the ExportWithCsvProfile pref and go on the circ/circulation.pl page. The export column appears, but not the export button. Test plan: Go on the checkout list (circ/circulation.pl and members/moremember.pl) and verify the export column and the export button appears. If you click on the button, a file should be generated. It does not work. Created attachment 33167 [details] [review] Bug 13190: Reintroduce the checkouts export feature Bug 11703 breaks the checkouts export feature. To reproduce: Fill the ExportWithCsvProfile pref and go on the circ/circulation.pl page. The export column appears, but not the export button. Test plan: Go on the checkout list (circ/circulation.pl and members/moremember.pl) and verify the export column and the export button appears. If you click on the button, a file should be generated. Created attachment 33169 [details] [review] Bug 13190: Reintroduce the checkouts export feature Bug 11703 breaks the checkouts export feature. To reproduce: Fill the ExportWithCsvProfile pref and go on the circ/circulation.pl page. The export column appears, but not the export button. Test plan: Go on the checkout list (circ/circulation.pl and members/moremember.pl) and verify the export column and the export button appears. If you click on the button, a file should be generated. If you do not have "Always show checkouts immediately" checked by default, the list of checkouts doesn't appear but the "export checkouts" form does. However, the "export checkouts" function doesn't work unless you have selected checkouts to export. I think the export form should be hidden by default along with the checkouts. Created attachment 33184 [details] [review] Bug 13190: Refactor the checkouts table template code This code is duplicated and should be centralised. (In reply to Owen Leonard from comment #5) > If you do not have "Always show checkouts immediately" checked by default, > the list of checkouts doesn't appear but the "export checkouts" form does. It worked on a view, not on the other. I copy the duplicated code into an include file in order to avoid this mistake later. > However, the "export checkouts" function doesn't work unless you have > selected checkouts to export. You would like to export all checkouts, that's it? This behavior is the same as before I think. Created attachment 33205 [details] [review] Bug 13190 [QA Followup] - Fix koha-qa.pl violations Created attachment 33207 [details] [review] [PASSED QA] Bug 13190: Reintroduce the checkouts export feature Bug 11703 breaks the checkouts export feature. To reproduce: Fill the ExportWithCsvProfile pref and go on the circ/circulation.pl page. The export column appears, but not the export button. Test plan: Go on the checkout list (circ/circulation.pl and members/moremember.pl) and verify the export column and the export button appears. If you click on the button, a file should be generated. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 33208 [details] [review] [SIGNED-OFF] Bug 13190: Reintroduce the checkouts export feature Bug 11703 breaks the checkouts export feature. To reproduce: Fill the ExportWithCsvProfile pref and go on the circ/circulation.pl page. The export column appears, but not the export button. Test plan: Go on the checkout list (circ/circulation.pl and members/moremember.pl) and verify the export column and the export button appears. If you click on the button, a file should be generated. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 33209 [details] [review] [SIGNED-OFF] Bug 13190: Refactor the checkouts table template code This code is duplicated and should be centralised. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 33210 [details] [review] [SIGNED-OFF] Bug 13190 [QA Followup] - Fix koha-qa.pl violations Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> > > However, the "export checkouts" function doesn't work unless you have
> > selected checkouts to export.
>
> You would like to export all checkouts, that's it?
> This behavior is the same as before I think.
I can confirm this is the original behavior ( as of 3.16.2 ).
Created attachment 33270 [details] [review] [PASSED QA] Bug 13190: Reintroduce the checkouts export feature Bug 11703 breaks the checkouts export feature. To reproduce: Fill the ExportWithCsvProfile pref and go on the circ/circulation.pl page. The export column appears, but not the export button. Test plan: Go on the checkout list (circ/circulation.pl and members/moremember.pl) and verify the export column and the export button appears. If you click on the button, a file should be generated. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 33271 [details] [review] [PASSED QA] Bug 13190: Refactor the checkouts table template code This code is duplicated and should be centralised. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Jonathan, is it possible that exporting today's check ins (using the entry in the toolbar) is also not working? I am not sure if I am missing configuraton. I returned some items and tried exporting, the file is empty. I tested the "export today's checkins" two ways: using the "check in" page - works as expected from a borrower who had returns that day using the tickboxes on the circulation screen and clicking "Return or renew items" (after clicking "show checkouts") - worked as expected for that borrower. I noted that borrowers that don't have any checkins today get an empty file, I assume that is how the feature is intended to work. Katrin - I hope this helps. :) Liz Patches pushed to master. Thanks Jonathan! potential inclusion for 3.16.x Pushed to 3.16.x, will be in 3.16.7 |