| Summary: | Fix tab order in cataloguing/item editor | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
| Component: | Staff interface | Assignee: | Marcel de Rooy <m.de.rooy> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | 1joynelson, gmcharlt, kyle, lucas |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.04
|
|
| Circulation function: | |||
| Bug Depends on: | 10480 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 13305: Fix tab order on three item editor forms
Bug 13305: Remove tabindex from PrepareItemsRecordDisplay Bug 13305: Remove tabindex from PrepareItemsRecordDisplay Bug 13305: Remove tabindex from PrepareItemsRecordDisplay |
||
|
Description
Marcel de Rooy
2014-11-20 08:08:28 UTC
Created attachment 33731 [details] [review] Bug 13305: Fix tab order on three item editor forms While working on bug 10480, I stumbled over the tab order on the forms serials-edit, acqui/addorderiso2709 and services/itemrecorddisplay. They all depend on C4::Items::PrepareItemrecordDisplay. Most of the inputs get a tabindex=1, but some don't. This creates a rather weird tab order for keyboard users (like me). By adjusting one input from C4::Items and the select in those three templates, the tab order is fixed. Test plan: [1] Set system preference AcqCreateItem to "placing an order". [2] Tab through the item fields on addorderiso2709. To do so, go to the Acquisition module, open a basket and add an order from a staged file. Click Add orders, go to Item information. [3] Tab through items fields on services/itemrecorddisplay. You could do this by creating a URL with biblionumber and itemnumber. But you can also test it via Acquisition. The script additem.js calls this perl script to create the item blocks on neworderempty. So again add an order to a basket, but choose for "From a new empty record". [4] Tab through item fields on serials-edit. Go to subscription detail. Click Receive. Choose "Click to add item". (Note that this subscription should create an item record when receiving this serial.) Is there any valid reason for having a tabindex value attached to any of these fields? I would prefer a solution which removed 'tabindex="1"' from the generated code rather than one which adds it. (In reply to Owen Leonard from comment #2) > Is there any valid reason for having a tabindex value attached to any of > these fields? I would prefer a solution which removed 'tabindex="1"' from > the generated code rather than one which adds it. Removing it everywhere involves more code changes. This touches just four lines now. So you are theoretically right, but I chose the pragmatic approach here. Will try to submit the more complete one as a follow-up on work for bug 10480. *** Bug 13137 has been marked as a duplicate of this bug. *** (In reply to Owen Leonard from comment #2) > Is there any valid reason for having a tabindex value attached to any of > these fields? I would prefer a solution which removed 'tabindex="1"' from > the generated code rather than one which adds it. I have taken the time to think deeply on that and came to appreciate it :) Patch forthcoming finally. Created attachment 97650 [details] [review] Bug 13305: Remove tabindex from PrepareItemsRecordDisplay Test plan: Check the tab order of the item block on additem.pl (item editor), Acquisition (neworderempty or addiso2709), serials-edit.pl. You could also check services/itemrecorddisplay.pl and pass a biblionumber; this script is used in additem.js for cataloguing and acquisition. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 98609 [details] [review] Bug 13305: Remove tabindex from PrepareItemsRecordDisplay Test plan: Check the tab order of the item block on additem.pl (item editor), Acquisition (neworderempty or addiso2709), serials-edit.pl. You could also check services/itemrecorddisplay.pl and pass a biblionumber; this script is used in additem.js for cataloguing and acquisition. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Most notably before this patch tabbing through the input fields would jump over the drop down fields. With the patch applied this seems to work much better. Created attachment 98613 [details] [review] Bug 13305: Remove tabindex from PrepareItemsRecordDisplay Test plan: Check the tab order of the item block on additem.pl (item editor), Acquisition (neworderempty or addiso2709), serials-edit.pl. You could also check services/itemrecorddisplay.pl and pass a biblionumber; this script is used in additem.js for cataloguing and acquisition. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work everyone! Pushed to master for 20.05 Pushed to 19.11.x branch for 19.11.04 backported to 19.05.x for 19.05.09 |