Summary: | The export tools is broken | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Tools | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | blocker | ||
Priority: | P5 - low | CC: | tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 13308: The output format should be 'iso2709' instead of 'marc'
Bug 13308: The output format should be 'iso2709' instead of 'marc' [SIGNED-OFF] Bug 13308: The output format should be 'iso2709' instead of 'marc' [PASSED QA] Bug 13308: The output format should be 'iso2709' instead of 'marc' |
Description
Jonathan Druart
2014-11-20 14:13:05 UTC
Created attachment 33740 [details] [review] Bug 13308: The output format should be 'iso2709' instead of 'marc' In the template of the export tools, the value 'marc' is set for the 'format' variable. It should be 'iso2709'. There was a mess in the tools/export.pl script. 2 variables did the same thing: $format and $output_format This patch fixes that replacing $format with $output_format Test plan: Try to export biblio in iso2709 and csv using the export tools and from the checkout list. Hum, wait, I still have local changes... Created attachment 33742 [details] [review] Bug 13308: The output format should be 'iso2709' instead of 'marc' In the template of the export tools, the value 'marc' is set for the 'format' variable. It should be 'iso2709'. There was a mess in the tools/export.pl script. 2 variables did the same thing: $format and $output_format This patch fixes that replacing $format with $output_format Test plan: Try to export biblio in iso2709 and csv using the export tools and from the checkout list. Created attachment 33748 [details] [review] [SIGNED-OFF] Bug 13308: The output format should be 'iso2709' instead of 'marc' In the template of the export tools, the value 'marc' is set for the 'format' variable. It should be 'iso2709'. There was a mess in the tools/export.pl script. 2 variables did the same thing: $format and $output_format This patch fixes that replacing $format with $output_format Test plan: Try to export biblio in iso2709 and csv using the export tools and from the checkout list. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Before applying the patch, attemping an MARC export from tools/export.pl resulted in an error. After the patch the export works correctly. Exports from the checkouts page also work correctly. Something I did not test: using the script from the command line to export records. Created attachment 33763 [details] [review] [PASSED QA] Bug 13308: The output format should be 'iso2709' instead of 'marc' In the template of the export tools, the value 'marc' is set for the 'format' variable. It should be 'iso2709'. There was a mess in the tools/export.pl script. 2 variables did the same thing: $format and $output_format This patch fixes that replacing $format with $output_format Test plan: Try to export biblio in iso2709 and csv using the export tools and from the checkout list. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Before applying the patch, attemping an MARC export from tools/export.pl resulted in an error. After the patch the export works correctly. Exports from the checkouts page also work correctly. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes tests and QA script. Also tested authority export. Patch pushed to master. Thanks Jonathan! |