Bug 13308 - The export tools is broken
Summary: The export tools is broken
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low blocker (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-20 14:13 UTC by Jonathan Druart
Modified: 2019-06-27 09:24 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 13308: The output format should be 'iso2709' instead of 'marc' (1.39 KB, patch)
2014-11-20 14:23 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 13308: The output format should be 'iso2709' instead of 'marc' (3.90 KB, patch)
2014-11-20 15:05 UTC, Jonathan Druart
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 13308: The output format should be 'iso2709' instead of 'marc' (4.19 KB, patch)
2014-11-20 16:48 UTC, Owen Leonard
Details | Diff | Splinter Review
[PASSED QA] Bug 13308: The output format should be 'iso2709' instead of 'marc' (4.26 KB, patch)
2014-11-20 18:39 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2014-11-20 14:13:05 UTC
Bug 13190 fixed the export on the checkout list but breaks the export tools...
Comment 1 Jonathan Druart 2014-11-20 14:23:05 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2014-11-20 15:05:03 UTC
Hum, wait, I still have local changes...
Comment 3 Jonathan Druart 2014-11-20 15:05:48 UTC Comment hidden (obsolete)
Comment 4 Owen Leonard 2014-11-20 16:48:47 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2014-11-20 16:55:56 UTC
Something I did not test: using the script from the command line to export records.
Comment 6 Katrin Fischer 2014-11-20 18:39:34 UTC
Created attachment 33763 [details] [review]
[PASSED QA] Bug 13308: The output format should be 'iso2709' instead of 'marc'

In the template of the export tools, the value 'marc' is set for
the 'format' variable.
It should be 'iso2709'.

There was a mess in the tools/export.pl script.
2 variables did the same thing: $format and $output_format

This patch fixes that replacing $format with $output_format

Test plan:
Try to export biblio in iso2709 and csv using the export tools and from
the checkout list.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Before applying the patch, attemping an MARC export from tools/export.pl
resulted in an error. After the patch the export works correctly.
Exports from the checkouts page also work correctly.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes tests and QA script. Also tested authority export.
Comment 7 Tomás Cohen Arazi 2014-11-20 21:20:52 UTC
Patch pushed to master.

Thanks Jonathan!