Bug 13349

Summary:	Allow library code to display against users pending changes
Product:	Koha	Reporter:	David Roberts <david.roberts>
Component:	Patrons	Assignee:	David Roberts <david.roberts>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	enhancement
Priority:	P5 - low	CC:	cbrannon, david.roberts, gmcharlt, kyle.m.hall, tomascohen, veron
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Bug Depends on:
Bug Blocks:	12028, 12352
Attachments:	Allow patron's library to display after patron updates details Version 2 of the patch [Signed-off] Bug 13349 - Allow library code to display against users pending changes -update screen [PASSED QA] Bug 13349 - Allow library code to display against users pending changes -update screen [PASSED QA] Bug 13349 [QA Followup]

Description David Roberts 2014-11-26 16:56:43 UTC

When OPACPatronDetails is set to Allow in a multi-library environment, it is sometimes useful if the library of the user submitting the change is visible to the staff member approving the change, so that each library can approve or deny the request from their own patrons. The attached patch corrects that. 

To test:

Ensure OPACPatronDetails is set to enabled
Apply the patch
Log into the OPAC and update your patron details (address, phone number etc)
Log into the staff client and view pending patron changes. 
The branchcode of the library to which the patron belongs should display next to the user's name.

Comment 1 David Roberts 2014-11-26 17:00:03 UTC Comment hidden (obsolete)

Created attachment 33958 [details] [review]
Allow patron's library to display after patron updates details

Comment 2 Christopher Brannon 2014-12-02 16:03:46 UTC

Traceback (most recent call last):
  File "/usr/local/bin/git-bz", line 2630, in <module>
    do_apply(*args)
  File "/usr/local/bin/git-bz", line 1755, in do_apply
    users = bug.server.get_xmlrpc_proxy().User.get({ 'names': [patch.attacher] })['users']
  File "/usr/lib/python2.6/xmlrpclib.py", line 1199, in __call__
    return self.__send(self.__name, args)
  File "/usr/lib/python2.6/xmlrpclib.py", line 1489, in __request
    verbose=self.__verbose
  File "/usr/lib/python2.6/xmlrpclib.py", line 1243, in request
    headers
xmlrpclib.ProtocolError: <ProtocolError for bugs.koha-community.org/xmlrpc.cgi: 404 Not Found>

Not sure if this is a problem on my end or what.

Christopher

Comment 3 Owen Leonard 2014-12-02 19:51:56 UTC

I get the same problem. It looks like the patch isn't formatted correctly?

Please resubmit the patch, and while you're at it, add a description of the bug and a test plan.

Comment 4 David Roberts 2014-12-02 22:44:45 UTC Comment hidden (obsolete)

Created attachment 34074 [details] [review]
Version 2 of the patch

Sorry, I don't know why the patch wouldn't apply - I've tried to regenerate it so hopefully it will work OK this time. 

To test:

1) Ensure OPACPatronDetails is set to enabled
2) Log into the OPAC and update your patron details (address, phone number etc)
3) Log into the staff client and view pending patron changes. 
The branchcode of the library to which the patron belongs will not display. 
4) Apply the patch
5) Log into the staff client again and view pending patron changes. 
The branchcode of the library to which the patron belongs should now display next to the user's name.

Comment 5 David Roberts 2014-12-02 22:57:29 UTC

I've tested this patch against a sandbox and it compiles OK. There is already a description of the enhancement in comment 1.

Comment 6 Owen Leonard 2014-12-02 23:32:43 UTC

Your second patch applied successfully using git-bz. Thanks for resubmitting.

Comment 7 Marc Véron 2014-12-05 16:54:16 UTC Comment hidden (obsolete)

Created attachment 34162 [details] [review]
[Signed-off] Bug 13349 - Allow library code to display against users pending changes -update screen

http://bugs.koha-community.org/show_bug.cgi?id=13349

To test:
Ensure OPACPatronDetails is set to enabled
Apply the patch
Log into the OPAC and update your patron details (address, phone number etc)
Log into the staff client and view pending patron changes.
The branchcode of the library to which the patron belongs should display next to the user's name.

Followed test plan, works as expected
Signed-off-by: Marc Véron <veron@veron.ch>

Comment 8 Kyle M Hall (khall) 2014-12-12 14:22:06 UTC

Created attachment 34349 [details] [review]
[PASSED QA] Bug 13349 - Allow library code to display against users pending changes -update screen

http://bugs.koha-community.org/show_bug.cgi?id=13349

To test:
Ensure OPACPatronDetails is set to enabled
Apply the patch
Log into the OPAC and update your patron details (address, phone number etc)
Log into the staff client and view pending patron changes.
The branchcode of the library to which the patron belongs should display next to the user's name.

Followed test plan, works as expected
Signed-off-by: Marc Veron <veron@veron.ch>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Comment 9 Kyle M Hall (khall) 2014-12-12 14:22:14 UTC

Created attachment 34350 [details] [review]
[PASSED QA] Bug 13349 [QA Followup]

I don't think we need the library label. Also switched to displaying the
library name, rather than just the branchcode.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Comment 10 Tomás Cohen Arazi (tcohen) 2015-04-09 17:59:39 UTC

Patches pushed to master.

Thanks David!