Bug 13596

Summary: Prevent updatedatabase.pl from reverting utf8_mb4 databases to utf8
Product: Koha Reporter: Martin Renvoize <martin.renvoize>
Component: Architecture, internals, and plumbingAssignee: Martin Renvoize <martin.renvoize>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: abl, benjamin.rokseth, bgkriegel, boutrosboutrosboutros, dpavlin, gwilliams, jonathan.druart, josef.moravec, katrin.fischer, m.de.rooy, magnus, martin.renvoize, tomascohen, ztajoli
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 11248, 11906, 11944, 13264    
Bug Blocks: 12832, 7380, 11844, 12176, 12637, 13239, 13577, 13579    
Attachments: BUG 13596: Prevent utf8mb4 -> utf8 convertion
BUG 13596: Prevent utf8mb4 -> utf8 convertion
BUG 13596: Prevent utf8mb4 -> utf8 convertion
BUG 13596: Prevent utf8mb4 -> utf8 convertion
BUG 13596: Prevent utf8mb4 -> utf8 convertion
BUG 13596: Prevent utf8mb4 -> utf8 convertion
[PASSED QA] BUG 13596: Prevent utf8mb4 -> utf8 convertion

Description Martin Renvoize 2015-01-19 15:42:35 UTC
Bug #11944 fixed utf8 encoding koha wide, however as part of it, it updates all database table to utf8 charset and utf8_unicode_ci collation.

This is a good thing for anyone who left the default coallition to being with, but is a step backwards for those working on Wheezy and Ubuntu who may have chosen the utf8_mb4 pragma.

The update should first check for such cases, and skip if found.
Comment 1 Martin Renvoize 2015-01-19 15:44:33 UTC Comment hidden (obsolete)
Comment 2 Martin Renvoize 2015-01-19 15:49:31 UTC Comment hidden (obsolete)
Comment 3 Martin Renvoize 2015-01-19 15:52:35 UTC Comment hidden (obsolete)
Comment 4 Martin Renvoize 2015-01-19 16:04:55 UTC Comment hidden (obsolete)
Comment 5 Martin Renvoize 2015-01-21 09:55:30 UTC Comment hidden (obsolete)
Comment 6 Jonathan Druart 2015-02-16 11:46:42 UTC Comment hidden (obsolete)
Comment 7 Kyle M Hall 2015-02-20 12:19:44 UTC
Created attachment 36071 [details] [review]
[PASSED QA] BUG 13596: Prevent utf8mb4 -> utf8 convertion

utf8mb4 is a superset of utf8 and thus is compatible.  We should not
force an entire db change upon people who have proactively set utf8mb4
encoding before now.

This patch also removed the deprecated use of ->tables stanza in favour
of the table_info stanza.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 8 Tomás Cohen Arazi 2015-02-20 14:14:33 UTC
Patch pushed to master.

Thanks Martin!