|
Description
Marc Véron
2015-03-14 15:58:35 UTC
Language selection is part of intranet-bottom.inc A fix of this rather cosmetic issue would need to create a separate 'bottom.inc' for such popups. Setting to RESOLVED WONTFIX Created attachment 62557 [details]
Popup window on a wide screen
On a wide screen results are visible
Created attachment 62558 [details]
Popup window on a narrower screen
Language selector turns into a list and hides the results
Reopend because the behaviour of language selector changed. It is no longer a cosmetic issue. Created attachment 62559 [details] [review] Bug 13835: Popup with searches: results hidden by language menu in footer Language menus in pop up windows are not necessary and can hide the contents (especially search results) on a narrow screen. For an example, see screenshot in comment #3 This patch allows to mark pop p menus not to display the language footer. To test: - Reproduce issue from comment #3 - Apply patch - Try to reproduce issue from comment #3 -> language menu should no longer display - Verify that language menu is suppresed in 'Add to ist' as well (from catalog search results, select an item, Add to:...) Note: There will be more pop-ups with unwnated language selector. That can be resolved in follow up bugs. Created attachment 62582 [details] [review] Bug 13835: Popup with searches: results hidden by language menu in footer Language menus in pop up windows are not necessary and can hide the contents (especially search results) on a narrow screen. For an example, see screenshot in comment #3 This patch allows to mark pop p menus not to display the language footer. To test: - Reproduce issue from comment #3 - Apply patch - Try to reproduce issue from comment #3 -> language menu should no longer display - Verify that language menu is suppresed in 'Add to ist' as well (from catalog search results, select an item, Add to:...) Note: There will be more pop-ups with unwnated language selector. That can be resolved in follow up bugs. Followed test plan which worked as intended Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> *** Bug 13837 has been marked as a duplicate of this bug. *** Created attachment 62626 [details] [review] Bug 13835: Popup with searches: results hidden by language menu in footer Language menus in pop up windows are not necessary and can hide the contents (especially search results) on a narrow screen. For an example, see screenshot in comment #3 This patch allows to mark pop p menus not to display the language footer. To test: - Reproduce issue from comment #3 - Apply patch - Try to reproduce issue from comment #3 -> language menu should no longer display - Verify that language menu is suppresed in 'Add to ist' as well (from catalog search results, select an item, Add to:...) Note: There will be more pop-ups with unwnated language selector. That can be resolved in follow up bugs. Followed test plan which worked as intended Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 17.05, thanks Marc! This patch has been pushed to 16.11.x and will be in 16.11.08. Pushed to 16.05.x, for 16.05.13 release |