Bug 13894

Summary: SQLHelper replacement - C4::Members::Search - reserve.pl
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: PatronsAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: gmcharlt, katrin.fischer, kyle.m.hall, tomascohen, veron
Version: Main   
Hardware: All   
OS: All   
See Also: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13926
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16197
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 12633, 13936    
Attachments: Bug 13894: Make reserve.pl not using C4::Members::Search
[Signed-off] Bug 13894: Make reserve.pl not using C4::Members::Search
[PASSED QA] Bug 13894: Make reserve.pl not using C4::Members::Search
Bug 13894: Fix if the search returns only 1 result

Description Jonathan Druart 2015-03-23 13:44:29 UTC
reserve/request.pl currently uses C4::Members::Search.
To get rid of SQLHelper, we should not use this subroutine anymore.
Comment 1 Jonathan Druart 2015-03-23 13:46:56 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2015-03-23 13:48:30 UTC
Note that this method will be applied to the circulation patron selection if this reach an agreement.
Comment 3 Marc Véron 2015-03-24 10:27:12 UTC Comment hidden (obsolete)
Comment 4 Kyle M Hall 2015-03-27 15:36:14 UTC
Created attachment 37330 [details] [review]
[PASSED QA] Bug 13894: Make reserve.pl not using C4::Members::Search

Important note: This will modify the UI.
The patron list will now be displayed in a table (instead of a select).

Test plan:
1/ Place a hold on a record
2/ Search for a patron
3/ Select a patron and submit
4/ The hold workflow should continue as previously

No behavior changes should be observed.

Works as expected.
Signed-off-by: Marc Veron <veron@veron.ch>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 5 Jonathan Druart 2015-03-30 10:07:03 UTC
Created attachment 37361 [details] [review]
Bug 13894: Fix if the search returns only 1 result

In the case where only 1 result is returned by the search, the
borrowernumber should be passed correctly.
Comment 6 Tomás Cohen Arazi 2015-03-30 16:16:51 UTC
Patch pushed to master.

Thanks Jonathan!
Comment 7 Jonathan Druart 2015-04-01 09:54:14 UTC
(In reply to Tomás Cohen Arazi from comment #6)
> Patch pushed to master.
> 
> Thanks Jonathan!

There is something wrong with the last past, the patrons search (using the checkout tab) is broken.
Working on it and will submit a patch asap.
Comment 8 Jonathan Druart 2015-04-01 10:04:15 UTC
Comment on attachment 37361 [details] [review]
Bug 13894: Fix if the search returns only 1 result

Review of attachment 37361 [details] [review]:
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
@@ +487,4 @@
>  [% END %]
>  
>  
> +[% IF ( borrowers ) %]

This change was for bug 13926.
Comment 9 Jonathan Druart 2015-04-01 10:07:57 UTC
Patch on bug 13936, sorry for that.