circ/circulation.pl currently uses C4::Members::Search. To get rid of SQLHelper, we should not use this subroutine anymore.
Created attachment 37362 [details] [review] Bug 13926: ake circulation.pl not using C4::Members::Search This patch uses the same method as bug 13894. Important note: This will modify the UI. The patron list will now be displayed in a table (instead of a select). Test plan: 1/ Search for a patron using the checkout tab 2/ The patron list should appear correctly Test with different type of search (returns 0, 1, 1+ results). No behavior changes should be observed.
Created attachment 37573 [details] [review] [SIGNED-OFF] Bug 13926: ake circulation.pl not using C4::Members::Search This patch uses the same method as bug 13894. Important note: This will modify the UI. The patron list will now be displayed in a table (instead of a select). Test plan: 1/ Search for a patron using the checkout tab 2/ The patron list should appear correctly Test with different type of search (returns 0, 1, 1+ results). No behavior changes should be observed. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> works as expected
Created attachment 37742 [details] [review] Bug 13926: Reintroduce the correct variable name in template It's caused by a mistake in previous patch, introduced by bug 13894 too late, then fixed by 13936. After this patch, all will be fine in any case :)
Created attachment 37743 [details] [review] [PASSED QA] Bug 13926: ake circulation.pl not using C4::Members::Search This patch uses the same method as bug 13894. Important note: This will modify the UI. The patron list will now be displayed in a table (instead of a select). Test plan: 1/ Search for a patron using the checkout tab 2/ The patron list should appear correctly Test with different type of search (returns 0, 1, 1+ results). No behavior changes should be observed. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> works as expected Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 37744 [details] [review] [PASSED QA] Bug 13926: Reintroduce the correct variable name in template It's caused by a mistake in previous patch, introduced by bug 13894 too late, then fixed by 13936. After this patch, all will be fine in any case :) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 37771 [details] [review] [PASSED QA] Bug 13926: ake circulation.pl not using C4::Members::Search This patch uses the same method as bug 13894. Important note: This will modify the UI. The patron list will now be displayed in a table (instead of a select). Test plan: 1/ Search for a patron using the checkout tab 2/ The patron list should appear correctly Test with different type of search (returns 0, 1, 1+ results). No behavior changes should be observed. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> works as expected Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Created attachment 37772 [details] [review] [PASSED QA] Bug 13926: Reintroduce the correct variable name in template It's caused by a mistake in previous patch, introduced by bug 13894 too late, then fixed by 13936. After this patch, all will be fine in any case :) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Rebased patches pushed to master. Thanks Jonathan!