Bug 14114

Summary: Silence warnings t/Debug.t
Product: Koha Reporter: Mark Tompsett <mtompset>
Component: Test SuiteAssignee: Mark Tompsett <mtompset>
Status: CLOSED FIXED QA Contact: Galen Charlton <gmcharlt>
Severity: minor    
Priority: P5 - low CC: bgkriegel, jonathan.druart, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 8879    
Attachments: Bug 14114: Silence warns and cleanup t/Debug.t
[SIGNED-OFF] Bug 14114: Silence warns and cleanup t/Debug.t
Bug 14114: Silence warns and cleanup t/Debug.t

Description Mark Tompsett 2015-05-01 21:13:14 UTC
Turns out there are annoying and pointless diags. Clean up. Fix layout. And perhaps even a Modern::Perl while I'm at it. :)
Comment 1 Mark Tompsett 2015-05-01 21:16:20 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2015-05-06 20:04:46 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2015-05-22 08:26:48 UTC
Created attachment 39381 [details] [review]
Bug 14114: Silence warns and cleanup t/Debug.t

TEST PLAN
---------
1) $ prove t/Debug.t
   -- What's with this BEFORE and AFTER stuff?!
2) apply patch
3) $ prove t/Debug.t
   -- cleaner, and you only get fuller output with -v.
4) koha qa test tools

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Cleaner, no koha-qa errors

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 4 Tomás Cohen Arazi 2015-05-22 14:18:40 UTC
Patch pushed to master.

Thanks Mark!