Turns out there are annoying and pointless diags. Clean up. Fix layout. And perhaps even a Modern::Perl while I'm at it. :)
Created attachment 38755 [details] [review] Bug 14114: Silence warns and cleanup t/Debug.t TEST PLAN --------- 1) $ prove t/Debug.t -- What's with this BEFORE and AFTER stuff?! 2) apply patch 3) $ prove t/Debug.t -- cleaner, and you only get fuller output with -v. 4) koha qa test tools
Created attachment 38905 [details] [review] [SIGNED-OFF] Bug 14114: Silence warns and cleanup t/Debug.t TEST PLAN --------- 1) $ prove t/Debug.t -- What's with this BEFORE and AFTER stuff?! 2) apply patch 3) $ prove t/Debug.t -- cleaner, and you only get fuller output with -v. 4) koha qa test tools Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Cleaner, no koha-qa errors
Created attachment 39381 [details] [review] Bug 14114: Silence warns and cleanup t/Debug.t TEST PLAN --------- 1) $ prove t/Debug.t -- What's with this BEFORE and AFTER stuff?! 2) apply patch 3) $ prove t/Debug.t -- cleaner, and you only get fuller output with -v. 4) koha qa test tools Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Cleaner, no koha-qa errors Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Patch pushed to master. Thanks Mark!