|
Description
Katrin Fischer
2015-05-13 08:46:36 UTC
This is a bit tricky, but maybe someone has an idea :) Created attachment 46910 [details] [review] Bug 14193 - Accessibility: Searching patrons using the alphabetic index doesn't work Using a mouse to click on the alphabetic index letters works even though the anchor markup doesn't contain an href attribute. However you can't tab to them using the keyboard, and I assume the issue with screen readers is related. This patch adds a dummy href attribute and a class-based click handler so that we can get rid of the "onclick" attribute in the markup. To test, apply the patch and visit the "Patrons" section. 1. Use the tab key to move the focus to one of the alphabet links. 2. Hit "Enter" and confirm that the search is performed correctly. 3. Click any of the alphabet links and confirm that clicking works as well. 4. View the details of any patron and click the "Add child" button. 5. In the "Guarantor information" section click the "Change" button. 6. In the search popup, use the tab key to move the focus to one of the alphabet links. 2. Hit "Enter" and confirm that the search is performed correctly. 3. Click any of the alphabet links and confirm that clicking works as well. Owen, I applied the patch and cleared my cache, but the tab is not going to the letters. Did I miss something? I'm in Firefox on Mac Nicole Created attachment 46941 [details] [review] Bug 14193 - Accessibility: Searching patrons using the alphabetic index doesn't work Using a mouse to click on the alphabetic index letters works even though the anchor markup doesn't contain an href attribute. However you can't tab to them using the keyboard, and I assume the issue with screen readers is related. This patch adds a dummy href attribute and a class-based click handler so that we can get rid of the "onclick" attribute in the markup. To test, apply the patch and visit the "Patrons" section. 1. Use the tab key to move the focus to one of the alphabet links. 2. Hit "Enter" and confirm that the search is performed correctly. 3. Click any of the alphabet links and confirm that clicking works as well. 4. View the details of any patron and click the "Add child" button. 5. In the "Guarantor information" section click the "Change" button. 6. In the search popup, use the tab key to move the focus to one of the alphabet links. 2. Hit "Enter" and confirm that the search is performed correctly. 3. Click any of the alphabet links and confirm that clicking works as well. Signed-off-by: Briana <brianagreally@gmail.com> Created attachment 46948 [details] [review] [PASSED QA] Bug 14193 - Accessibility: Searching patrons using the alphabetic index doesn't work Using a mouse to click on the alphabetic index letters works even though the anchor markup doesn't contain an href attribute. However you can't tab to them using the keyboard, and I assume the issue with screen readers is related. This patch adds a dummy href attribute and a class-based click handler so that we can get rid of the "onclick" attribute in the markup. To test, apply the patch and visit the "Patrons" section. 1. Use the tab key to move the focus to one of the alphabet links. 2. Hit "Enter" and confirm that the search is performed correctly. 3. Click any of the alphabet links and confirm that clicking works as well. 4. View the details of any patron and click the "Add child" button. 5. In the "Guarantor information" section click the "Change" button. 6. In the search popup, use the tab key to move the focus to one of the alphabet links. 2. Hit "Enter" and confirm that the search is performed correctly. 3. Click any of the alphabet links and confirm that clicking works as well. Signed-off-by: Briana <brianagreally@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Thx a lot for this, I had no idea where to start! Pushed to Master - Should be in the May 2016 release. - Thanks! Patch pushed to 3.22.x, will be in 3.22.2 This patch has been pushed to 3.20.x, will be in 3.20.8. |