Description
Lari Taskula
2015-09-22 14:11:31 UTC
Created attachment 42840 [details] [review] Bug 14872: Reminder to update SMSnumber when primary phone is updated Since SMS number (smsalertnumber) and primary phone are separated, it would be useful to remind patron to update his/her SMS number when making changes to primary phone. This can easily be forgotten, especially in OPAC where the two fields are in different page (opac-memberentry.pl vs opac-messaging.pl). This patch adds a reminder in the "hint"-div that activates whenever phone field gets input (and phone-smsalertnumber do not match). To test: 1. Enable SMSSendDriver and EnhancedMessagingPreferences system preferences 2. Navigate to OPAC -> your personal details 3. Input something to primary phone. You should not be notified at all 4. Navigate to Intra -> Patron -> Edit 5. Repeat step 3 6. Apply patch 7. Refresh Opac -> your personal details and Intra -> Patron -> Edit 8. Input something to primary phone and observe you will be notified to also update SMS number. Created attachment 42841 [details] [review] Bug 14872: Reminder to update SMSnumber when primary phone is updated Created attachment 47624 [details] [review] Bug 14872: Reminder to update SMSnumber when primary phone is updated Since SMS number (smsalertnumber) and primary phone are separated, it would be useful to remind patron to update his/her SMS number when making changes to primary phone. This can easily be forgotten, especially in OPAC where the two fields are in different page (opac-memberentry.pl vs opac-messaging.pl). This patch adds a reminder in the "hint"-div that activates whenever phone field gets input (and phone-smsalertnumber do not match). To test: 1. Enable SMSSendDriver and EnhancedMessagingPreferences system preferences 2. Navigate to OPAC -> your personal details 3. Input something to primary phone. You should not be notified at all 4. Navigate to Intra -> Patron -> Edit 5. Repeat step 3 6. Apply patch 7. Refresh Opac -> your personal details and Intra -> Patron -> Edit 8. Input something to primary phone and observe you will be notified to also update SMS number. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Fixed a small merge conflict in opac-memberentry.tt I don't get the message at the OPAC. The SMSSendDriver value should be checked using the TT plugin (Koha.Preference). I don't know if we need a pref to control this behavior, maybe other libraries don't use the primary phone as the mobile phone. (In reply to Jonathan Druart from comment #4) > I don't get the message at the OPAC. > > The SMSSendDriver value should be checked using the TT plugin > (Koha.Preference). > I don't know if we need a pref to control this behavior, maybe other > libraries don't use the primary phone as the mobile phone. I am a bit worried about that too. We offer, I think, 3 phone number fields, and some might have the habit/custom to put the landline in the first field and the mobile/work number in another, especially since one of the fields were once labelled differently. I wonder if a better long-term solution wouldn't be to have the SMS number field be an option to select one of the existing phone number fields: A dropdown menu where you choose to link SMS messages to primary phone, secondary phone, or other phone. It seems odd to me that we even have a separate field for SMS number. (In reply to Owen Leonard from comment #6) > I wonder if a better long-term solution wouldn't be to have the SMS number > field be an option to select one of the existing phone number fields: A > dropdown menu where you choose to link SMS messages to primary phone, > secondary phone, or other phone. It seems odd to me that we even have a > separate field for SMS number. Right? Hmm, is there a valid use case for people to have a distinct SMS alert number compared to their other numbers at all? I feel like we should/could drop the field from borrowers entirely and impliment a preference to say which of our phone fields is used globally as the SMS alert number.. but that does reduce options for end users if they do want one mobile for calls and another number for texts? Does the above case actually exist in the real world . I don't know |