| Summary: | Add qualifier menu to staff side "Search the Catalog" | ||
|---|---|---|---|
| Product: | Koha | Reporter: | HB-NEKLS <gwilliams> |
| Component: | Searching | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | amy, barton, jonathan.druart, jschmidt, kyle, nick, nicole, sally.healey, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | Sponsored | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
The main OPAC search has a qualifier menu available (the Search: Library Catalog/Title/Author/Subject/ISBN/Series/Call Number menu). Now the staff side had this option available, too. Show/Not show with syspref 'IntranetCatalogSearchPulldown'.
|
Version(s) released in: | |
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 16799, 19046 | ||
| Attachments: |
Bug 14902 - Add qualifier menu to staff side "Search the Catalog"
Shows combo bar without menu -- normal position. Shows search bar with menu, pushed below logo. Bug 14902 - Add qualifier menu to staff side "Search the Catalog" [SIGNED-OFF] Bug 14902 - Add qualifier menu to staff side "Search the Catalog" Bug 14902 (QA Followup) Bug 14902 - Add qualifier menu to staff side "Search the Catalog" |
||
|
Description
HB-NEKLS
2015-09-25 16:27:48 UTC
*** Bug 15132 has been marked as a duplicate of this bug. *** Created attachment 52021 [details] [review] Bug 14902 - Add qualifier menu to staff side "Search the Catalog" To test: 1 - Apply patch and update dabase 2 - Check that Search the Catalog links throughout the staff interface have not changed 3 - Set "IntranetCatalogSearchPulldown" to 'Show' 4 - Verify that 'Search the catalog' links through staff client now have a dropdwon to select search index I think viewing one file each that includes updated header should be sufficient, but please check as many as you can: cgi-bin/koha/admin/aqbudgetperiods.pl cgi-bin/koha/admin/admin-home.pl cgi-bin/koha/cataloguing/addbooks.pl cgi-bin/koha/circ/returns.pl cgi-bin/koha/circ/circulation-home.pl cgi-bin/koha/admin/cities.pl cgi-bin/koha/admin/aqcontract.pl cgi-bin/koha/admin/currency.pl cgi-bin/koha/mainpage.pl cgi-bin/koha/tools/letter.pl cgi-bin/koha/members/members-home.pl cgi-bin/koha/admin/categories.pl cgi-bin/koha/admin/preferences.pl cgi-bin/koha/admin/printers.pl cgi-bin/koha/serials/serials-home.pl cgi-bin/koha/acqui/newordersuggestion.pl cgi-bin/koha/admin/z3950servers.pl Sponsored by: Northeast Kansas Library System (http://nekls.org/) Created attachment 52654 [details]
Shows combo bar without menu -- normal position.
Created attachment 52655 [details]
Shows search bar with menu, pushed below logo.
(In reply to Nick Clemens from comment #2) > Created attachment 52021 [details] [review] [review] > Bug 14902 - Add qualifier menu to staff side "Search the Catalog" > > To test: > 1 - Apply patch and update dabase > 2 - Check that Search the Catalog links throughout the staff interface > have not changed > 3 - Set "IntranetCatalogSearchPulldown" to 'Show' > 4 - Verify that 'Search the catalog' links through staff client now have > a dropdwon to select search index > > I think viewing one file each that includes updated header should be > sufficient, but please check as many as you can: > > cgi-bin/koha/admin/aqbudgetperiods.pl > cgi-bin/koha/admin/admin-home.pl > cgi-bin/koha/cataloguing/addbooks.pl > cgi-bin/koha/circ/returns.pl > cgi-bin/koha/circ/circulation-home.pl > cgi-bin/koha/admin/cities.pl > cgi-bin/koha/admin/aqcontract.pl > cgi-bin/koha/admin/currency.pl > cgi-bin/koha/mainpage.pl > cgi-bin/koha/tools/letter.pl > cgi-bin/koha/members/members-home.pl > cgi-bin/koha/admin/categories.pl > cgi-bin/koha/admin/preferences.pl > cgi-bin/koha/admin/printers.pl > cgi-bin/koha/serials/serials-home.pl > cgi-bin/koha/acqui/newordersuggestion.pl > cgi-bin/koha/admin/z3950servers.pl > > Sponsored by: > Northeast Kansas Library System (http://nekls.org/) I've verified that the dropdown is present on the catalog search on the pages above. The one thing that I noticed was that below a certain screen width, the width of the searchbox + the dropdown forces the catalog search below the Koha logo. Because this happens when you click 'Search the catalog', this resizing is a bit jarring. See the attached 'checkout_bar.png' and 'search_bar.png' (In reply to Barton Chittenden from comment #5) (...) > > The one thing that I noticed was that below a certain screen width, the > width of the searchbox + the dropdown forces the catalog search below the > Koha logo. > > Because this happens when you click 'Search the catalog', this resizing is a > bit jarring. > > See the attached 'checkout_bar.png' and 'search_bar.png' Hi Barton, That happens with and without patch, maybe it could be fixed with CSS that takes in account the screen width. Can you file a new bug for that? Created attachment 52745 [details] [review] Bug 14902 - Add qualifier menu to staff side "Search the Catalog" To test: 1 - Apply patch and update dabase 2 - Check that Search the Catalog links throughout the staff interface have not changed 3 - Set "IntranetCatalogSearchPulldown" to 'Show' 4 - Verify that 'Search the catalog' links through staff client now have a dropdwon to select search index I think viewing one file each that includes updated header should be sufficient, but please check as many as you can: cgi-bin/koha/admin/aqbudgetperiods.pl cgi-bin/koha/admin/admin-home.pl cgi-bin/koha/cataloguing/addbooks.pl cgi-bin/koha/circ/returns.pl cgi-bin/koha/circ/circulation-home.pl cgi-bin/koha/admin/cities.pl cgi-bin/koha/admin/aqcontract.pl cgi-bin/koha/admin/currency.pl cgi-bin/koha/mainpage.pl cgi-bin/koha/tools/letter.pl cgi-bin/koha/members/members-home.pl cgi-bin/koha/admin/categories.pl cgi-bin/koha/admin/preferences.pl cgi-bin/koha/admin/printers.pl cgi-bin/koha/serials/serials-home.pl cgi-bin/koha/acqui/newordersuggestion.pl cgi-bin/koha/admin/z3950servers.pl Sponsored by: Northeast Kansas Library System (http://nekls.org/) Signed-off-by: Heather Braum <hbraum@nekls.org> Created attachment 52763 [details] [review] [SIGNED-OFF] Bug 14902 - Add qualifier menu to staff side "Search the Catalog" To test: 1 - Apply patch and update dabase 2 - Check that Search the Catalog links throughout the staff interface have not changed 3 - Set "IntranetCatalogSearchPulldown" to 'Show' 4 - Verify that 'Search the catalog' links through staff client now have a dropdwon to select search index I think viewing one file each that includes updated header should be sufficient, but please check as many as you can: cgi-bin/koha/admin/aqbudgetperiods.pl cgi-bin/koha/admin/admin-home.pl cgi-bin/koha/cataloguing/addbooks.pl cgi-bin/koha/circ/returns.pl cgi-bin/koha/circ/circulation-home.pl cgi-bin/koha/admin/cities.pl cgi-bin/koha/admin/aqcontract.pl cgi-bin/koha/admin/currency.pl cgi-bin/koha/mainpage.pl cgi-bin/koha/tools/letter.pl cgi-bin/koha/members/members-home.pl cgi-bin/koha/admin/categories.pl cgi-bin/koha/admin/preferences.pl cgi-bin/koha/admin/printers.pl cgi-bin/koha/serials/serials-home.pl cgi-bin/koha/acqui/newordersuggestion.pl cgi-bin/koha/admin/z3950servers.pl Sponsored by: Northeast Kansas Library System (http://nekls.org/) Signed-off-by: Heather Braum <hbraum@nekls.org> Signed-off-by: Barton Chittenden <barton@bywatersolutions.com> Nick, Why do you add [% USE Koha %] in some templates? The Koha TT plugin is loaded in doc-head-open.inc and should then be everywhere else. Created attachment 52866 [details] [review] Bug 14902 (QA Followup) Remove unnecessary [% USE Koha %] Any remaining were tested and needed Created attachment 52874 [details] [review] Bug 14902 - Add qualifier menu to staff side "Search the Catalog" To test: 1 - Apply patch and update dabase 2 - Check that Search the Catalog links throughout the staff interface have not changed 3 - Set "IntranetCatalogSearchPulldown" to 'Show' 4 - Verify that 'Search the catalog' links through staff client now have a dropdwon to select search index I think viewing one file each that includes updated header should be sufficient, but please check as many as you can: cgi-bin/koha/admin/aqbudgetperiods.pl cgi-bin/koha/admin/admin-home.pl cgi-bin/koha/cataloguing/addbooks.pl cgi-bin/koha/circ/returns.pl cgi-bin/koha/circ/circulation-home.pl cgi-bin/koha/admin/cities.pl cgi-bin/koha/admin/aqcontract.pl cgi-bin/koha/admin/currency.pl cgi-bin/koha/mainpage.pl cgi-bin/koha/tools/letter.pl cgi-bin/koha/members/members-home.pl cgi-bin/koha/admin/categories.pl cgi-bin/koha/admin/preferences.pl cgi-bin/koha/admin/printers.pl cgi-bin/koha/serials/serials-home.pl cgi-bin/koha/acqui/newordersuggestion.pl cgi-bin/koha/admin/z3950servers.pl Sponsored by: Northeast Kansas Library System (http://nekls.org/) Signed-off-by: Heather Braum <hbraum@nekls.org> Signed-off-by: Barton Chittenden <barton@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (In reply to Nick Clemens from comment #10) > Created attachment 52866 [details] [review] [review] > Bug 14902 (QA Followup) > > Remove unnecessary [% USE Koha %] > > Any remaining were tested and needed Indeed, that's weird. So I prefer to keep the original patch, which has been widely tested. Sorry for the extra work. Pushed to master for 16.11, thanks Nick! |