Summary: | search_utf8.t fails to upload a file | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Test Suite | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Galen Charlton <gmcharlt> |
Severity: | minor | ||
Priority: | P5 - low | CC: | jonathan.druart, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 14321 | ||
Bug Blocks: | 14909 | ||
Attachments: |
Bug 14905: Search_utf8.t fails to upload a file
Bug 14905: Search_utf8.t fails to upload a file |
Description
Marcel de Rooy
2015-09-28 08:41:48 UTC
Created attachment 42903 [details] [review] Bug 14905: Search_utf8.t fails to upload a file Running the test fails on test 7: not ok 7 - upload succeeded The changes on bug 14321 included a temp flag for script upload-file.pl. Since this upload for stage-marc-import should be temporary, adding this flag to line 131 resolves the problem. Test plan: Run the adjusted test. NOTE: I still had some problems with this test. And will still be looking to these errors (perhaps open a new report). But this fix should at least fix the above-mentioned test. (In reply to Marcel de Rooy from comment #1) > NOTE: I still had some problems with this test. And will still be looking > to these errors (perhaps open a new report). But this fix should at least > fix the above-mentioned test. I had warnings on test 27 and test 59 too about a empty kw= missing in the base. Will address these warnings on bug 14909. (In reply to Marcel de Rooy from comment #2) > (In reply to Marcel de Rooy from comment #1) > > NOTE: I still had some problems with this test. And will still be looking > > to these errors (perhaps open a new report). But this fix should at least > > fix the above-mentioned test. > > I had warnings on test 27 and test 59 too about a empty kw= missing in the > base. > Will address these warnings on bug 14909. kw= should be read as idx= :) Created attachment 42909 [details] [review] Bug 14905: Search_utf8.t fails to upload a file Running the test fails on test 7: not ok 7 - upload succeeded The changes on bug 14321 included a temp flag for script upload-file.pl. Since this upload for stage-marc-import should be temporary, adding this flag to line 131 resolves the problem. Test plan: Run the adjusted test. NOTE: I still had some problems with this test. And will still be looking to these errors (perhaps open a new report). But this fix should at least fix the above-mentioned test. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Taking the liberty to pass QA on it, small patch and no QA activities at the moment... Patch pushed to master. Thanks Marcel! |