Bug 14905 - search_utf8.t fails to upload a file
Summary: search_utf8.t fails to upload a file
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Marcel de Rooy
QA Contact: Galen Charlton
URL:
Whiteboard:
Keywords:
Depends on: 14321
Blocks: 14909
  Show dependency treegraph
 
Reported: 2015-09-28 08:41 UTC by Marcel de Rooy
Modified: 2016-06-21 21:40 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 14905: Search_utf8.t fails to upload a file (1.29 KB, patch)
2015-09-28 09:04 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 14905: Search_utf8.t fails to upload a file (1.31 KB, patch)
2015-09-28 11:26 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2015-09-28 08:41:48 UTC
Follow-up from error reported on bug 14321
Comment 1 Marcel de Rooy 2015-09-28 09:04:45 UTC Comment hidden (obsolete)
Comment 2 Marcel de Rooy 2015-09-28 09:54:01 UTC
(In reply to Marcel de Rooy from comment #1)
> NOTE: I still had some problems with this test. And will still be looking
> to these errors (perhaps open a new report). But this fix should at least
> fix the above-mentioned test.

I had warnings on test 27 and test 59 too about a empty kw= missing in the base.
Will address these warnings on bug 14909.
Comment 3 Marcel de Rooy 2015-09-28 10:54:58 UTC
(In reply to Marcel de Rooy from comment #2)
> (In reply to Marcel de Rooy from comment #1)
> > NOTE: I still had some problems with this test. And will still be looking
> > to these errors (perhaps open a new report). But this fix should at least
> > fix the above-mentioned test.
> 
> I had warnings on test 27 and test 59 too about a empty kw= missing in the
> base.
> Will address these warnings on bug 14909.

kw= should be read as idx= :)
Comment 4 Jonathan Druart 2015-09-28 11:26:41 UTC
Created attachment 42909 [details] [review]
Bug 14905: Search_utf8.t fails to upload a file

Running the test fails on test 7:
not ok 7 - upload succeeded

The changes on bug 14321 included a temp flag for script upload-file.pl.
Since this upload for stage-marc-import should be temporary, adding this
flag to line 131 resolves the problem.

Test plan:
Run the adjusted test.
NOTE: I still had some problems with this test. And will still be looking
to these errors (perhaps open a new report). But this fix should at least
fix the above-mentioned test.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Jonathan Druart 2015-09-28 11:28:13 UTC
Taking the liberty to pass QA on it, small patch and no QA activities at the moment...
Comment 6 Tomás Cohen Arazi 2015-09-28 15:14:03 UTC
Patch pushed to master.

Thanks Marcel!