Bug 14909 - Warnings from search_utf8.t when empty idx= misses in returned base
Summary: Warnings from search_utf8.t when empty idx= misses in returned base
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Marcel de Rooy
QA Contact: Galen Charlton
URL:
Whiteboard:
Keywords:
Depends on: 14905
Blocks:
  Show dependency treegraph
 
Reported: 2015-09-28 09:52 UTC by Marcel de Rooy
Modified: 2016-06-21 21:40 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 14909: Warnings from search_utf8.t when empty idx= misses in base (2.65 KB, patch)
2015-09-28 10:22 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 14909: Warnings from search_utf8.t when empty idx= misses in base (2.68 KB, patch)
2015-09-28 11:26 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2015-09-28 09:52:42 UTC

    
Comment 1 Marcel de Rooy 2015-09-28 09:55:21 UTC
The regex in this test looks like:
opac-search.pl\?idx=&q=%CE%91%CE%B8%CE%AE%CE%BD%CE%B1
The result it got was:
opac-search.pl?q=%CE%91%CE%B8%CE%AE%CE%BD%CE%B1

Note that it fails on the missing idx=
Comment 2 Marcel de Rooy 2015-09-28 10:22:50 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2015-09-28 11:26:56 UTC
Created attachment 42910 [details] [review]
Bug 14909: Warnings from search_utf8.t when empty idx= misses in base

The regex in this test looks like:
  opac-search.pl\?idx=&q=%CE%91%CE%B8%CE%AE%CE%BD%CE%B1
The result it got was:
  opac-search.pl?q=%CE%91%CE%B8%CE%AE%CE%BD%CE%B1

The empty idx should not be a reason to fail the test. I changed the
original regex to make the 'idx=&' part optional and added a base_unlike
test to verify that the base does not include a idx=\w+ anywhere.

Also corrected the typo Goog. Good!

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
All 66 tests now pass with me.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jonathan Druart 2015-09-28 11:28:04 UTC
Taking the liberty to pass QA on it, small patch and no QA activities at the moment...
Comment 5 Tomás Cohen Arazi 2015-09-28 15:14:26 UTC
Patch pushed to master.

Thanks Marcel!