| Summary: | Warnings from search_utf8.t when empty idx= misses in returned base | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
| Component: | Test Suite | Assignee: | Marcel de Rooy <m.de.rooy> |
| Status: | CLOSED FIXED | QA Contact: | Galen Charlton <gmcharlt> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | jonathan.druart, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 14905 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 14909: Warnings from search_utf8.t when empty idx= misses in base
Bug 14909: Warnings from search_utf8.t when empty idx= misses in base |
||
|
Description
Marcel de Rooy
2015-09-28 09:52:42 UTC
The regex in this test looks like: opac-search.pl\?idx=&q=%CE%91%CE%B8%CE%AE%CE%BD%CE%B1 The result it got was: opac-search.pl?q=%CE%91%CE%B8%CE%AE%CE%BD%CE%B1 Note that it fails on the missing idx= Created attachment 42907 [details] [review] Bug 14909: Warnings from search_utf8.t when empty idx= misses in base The regex in this test looks like: opac-search.pl\?idx=&q=%CE%91%CE%B8%CE%AE%CE%BD%CE%B1 The result it got was: opac-search.pl?q=%CE%91%CE%B8%CE%AE%CE%BD%CE%B1 The empty idx should not be a reason to fail the test. I changed the original regex to make the 'idx=&' part optional and added a base_unlike test to verify that the base does not include a idx=\w+ anywhere. Also corrected the typo Goog. Good! Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> All 66 tests now pass with me. Created attachment 42910 [details] [review] Bug 14909: Warnings from search_utf8.t when empty idx= misses in base The regex in this test looks like: opac-search.pl\?idx=&q=%CE%91%CE%B8%CE%AE%CE%BD%CE%B1 The result it got was: opac-search.pl?q=%CE%91%CE%B8%CE%AE%CE%BD%CE%B1 The empty idx should not be a reason to fail the test. I changed the original regex to make the 'idx=&' part optional and added a base_unlike test to verify that the base does not include a idx=\w+ anywhere. Also corrected the typo Goog. Good! Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> All 66 tests now pass with me. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Taking the liberty to pass QA on it, small patch and no QA activities at the moment... Patch pushed to master. Thanks Marcel! |