Summary: | Add diagnostic for the TestBuilder tests | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 15052: Add diagnostic for the TestBuilder tests
Bug 15052: Add diagnostic for the TestBuilder tests |
Description
Jonathan Druart
2015-10-23 08:32:11 UTC
Created attachment 43807 [details] [review] Bug 15052: Add diagnostic for the TestBuilder tests Sometimes t/db_dependent/TestBuilder.t fails with 'TestBuilder can create a entry for every sources' but we don't know which ones have failed. Test plan: Create the following file: Koha/Schema/Result/Test.pm package Koha::Schema::Result::Test; use base 'DBIx::Class::Core'; __PACKAGE__->table("test"); 1; If you don't have a table named 'test' in your DB, prove t/db_dependent/TestBuilder.t should return a failure, but without any explanation. With this patch you should get a diag and know what's wrong. Created attachment 43826 [details] [review] Bug 15052: Add diagnostic for the TestBuilder tests Sometimes t/db_dependent/TestBuilder.t fails with 'TestBuilder can create a entry for every sources' but we don't know which ones have failed. Test plan: Create the following file: Koha/Schema/Result/Test.pm package Koha::Schema::Result::Test; use base 'DBIx::Class::Core'; __PACKAGE__->table("test"); 1; If you don't have a table named 'test' in your DB, prove t/db_dependent/TestBuilder.t should return a failure, but without any explanation. With this patch you should get a diag and know what's wrong. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Patch pushed to master. I was thinking of doing the same! Thanks Jonathan! |