Bug 15052 - Add diagnostic for the TestBuilder tests
Summary: Add diagnostic for the TestBuilder tests
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-23 08:32 UTC by Jonathan Druart
Modified: 2016-06-21 21:40 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 15052: Add diagnostic for the TestBuilder tests (1.77 KB, patch)
2015-10-23 08:35 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15052: Add diagnostic for the TestBuilder tests (1.82 KB, patch)
2015-10-23 12:36 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2015-10-23 08:32:11 UTC
Sometimes t/db_dependent/TestBuilder.t fails with 'TestBuilder can create a entry for every sources' but we don't know which ones have failed.
Comment 1 Jonathan Druart 2015-10-23 08:35:17 UTC Comment hidden (obsolete)
Comment 2 Tomás Cohen Arazi 2015-10-23 12:36:46 UTC
Created attachment 43826 [details] [review]
Bug 15052: Add diagnostic for the TestBuilder tests

Sometimes t/db_dependent/TestBuilder.t fails with 'TestBuilder can
create a entry for every sources' but we don't know which ones have
failed.

Test plan:
Create the following file: Koha/Schema/Result/Test.pm
 package Koha::Schema::Result::Test;
 use base 'DBIx::Class::Core';
 __PACKAGE__->table("test");
 1;

If you don't have a table named 'test' in your DB,
  prove t/db_dependent/TestBuilder.t
should return a failure, but without any explanation.
With this patch you should get a diag and know what's wrong.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 3 Tomás Cohen Arazi 2015-10-23 12:56:42 UTC
Patch pushed to master.

I was thinking of doing the same! Thanks Jonathan!