|
Description
Owen Leonard
2015-12-02 17:26:37 UTC
Can someone tell yet how bad of a rewrite this will cause? Created attachment 45639 [details] [review] Bug 15285: Upgrade DataTables to 1.10.10 The ColVis DataTables plugin is now retired. We need to upgrade the plugin to 1.10.10 and use the column visibility module for Buttons. Created attachment 45640 [details] [review] Bug 15285: Update common files Created attachment 45641 [details] [review] Bug 15285: POC with currency.tt This change will have to be done for all templates currently using the ColVis plugin. (In reply to Katrin Fischer from comment #1) > Can someone tell yet how bad of a rewrite this will cause? Looks quite easy. Glad to hear that :) Tested, works with currency table and with Bug 15471. Status is "New" at the moment, does it need Sign-off or are there updates to come? Created attachment 46484 [details] [review] Bug 15285: Update common files This patch moves the Button area all tables which does not redefine the dom/sDom DT parameter. Created attachment 46485 [details] [review] Bug 15285: Update for 3 specific tables The checkouts, currency and items lost tables redefine the dom/sDom and the older C(olvis) should be replaced with the current B(utton). Test plan: To test the whole patch set, you will have to test the 4 tables impacted by this patch as well as the others using the columns settings. The additem has specific code and should be tested keeping that in mind. I let CSS experts modify the style of the new button :) Created attachment 46683 [details]
Screenshots table 'All funds'
With patch the table "All funds" looks weird.
Created attachment 46686 [details] [review] Bug 15285: Fix conflict with the treetable plugin The tables using the treetable plugin don't display correctly (with JS error). The lazy way to fix it is to redefine the dom of the table and remove the button area (B). (In reply to Marc Véron from comment #11) > Created attachment 46683 [details] > Screenshots table 'All funds' > > With patch the table "All funds" looks weird. Thanks, good catch! Created attachment 47261 [details] [review] Bug 15285: Upgrade DataTables to 1.10.10 The ColVis DataTables plugin is now retired. We need to upgrade the plugin to 1.10.10 and use the column visibility module for Buttons. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 47263 [details] [review] Bug 15285: Update common files This patch moves the Button area all tables which does not redefine the dom/sDom DT parameter. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 47264 [details] [review] Bug 15285: Update for 3 specific tables The checkouts, currency and items lost tables redefine the dom/sDom and the older C(olvis) should be replaced with the current B(utton). Test plan: To test the whole patch set, you will have to test the 4 tables impacted by this patch as well as the others using the columns settings. The additem has specific code and should be tested keeping that in mind. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 47266 [details] [review] Bug 15285: Fix conflict with the treetable plugin The tables using the treetable plugin don't display correctly (with JS error). The lazy way to fix it is to redefine the dom of the table and remove the button area (B). Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 47688 [details] [review] Bug 15285: Upgrade DataTables to 1.10.10 The ColVis DataTables plugin is now retired. We need to upgrade the plugin to 1.10.10 and use the column visibility module for Buttons. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 47689 [details] [review] Bug 15285: Update common files This patch moves the Button area all tables which does not redefine the dom/sDom DT parameter. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 47690 [details] [review] Bug 15285: Update for 3 specific tables The checkouts, currency and items lost tables redefine the dom/sDom and the older C(olvis) should be replaced with the current B(utton). Test plan: To test the whole patch set, you will have to test the 4 tables impacted by this patch as well as the others using the columns settings. The additem has specific code and should be tested keeping that in mind. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 47691 [details] [review] Bug 15285: Fix conflict with the treetable plugin The tables using the treetable plugin don't display correctly (with JS error). The lazy way to fix it is to redefine the dom of the table and remove the button area (B). Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> pushed to Master - Should be in the May 2016 Release. Thanks More an enhancement than a bug, changing severity |