Bug 16177 - Tests for ColumnsSettings are failing
Summary: Tests for ColumnsSettings are failing
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 15285
Blocks:
  Show dependency treegraph
 
Reported: 2016-03-31 07:59 UTC by Jonathan Druart
Modified: 2016-12-05 21:23 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16177: Fix tests for ColumnsSsettings.t (3.04 KB, patch)
2016-03-31 08:02 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 16177: Fix tests for ColumnsSsettings.t (3.19 KB, patch)
2016-04-01 04:41 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 16177: Fix tests for ColumnsSsettings.t (3.30 KB, patch)
2016-04-01 08:04 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2016-03-31 07:59:23 UTC

    
Comment 1 Jonathan Druart 2016-03-31 08:02:52 UTC Comment hidden (obsolete)
Comment 2 Mark Tompsett 2016-04-01 04:41:09 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2016-04-01 08:04:32 UTC
Created attachment 49773 [details] [review]
Bug 16177: Fix tests for ColumnsSsettings.t

This failure has been introduced by
  commit 243b797dd11bc0ac1f475195ab765ffbf2220f8b
    Bug 15285: Update common files

This is because the cannot_be_modified key is not always created by
C4::Utils::DataTables::ColumnsSettings subroutines

Test plan:
  prove t/db_dependent/ColumnsSettings.t
should return green
And you can also test a table where the feature is set and a column
cannot be modified from the admin page.

NOTE: Works as described. I was pondering this potential
      solution when I found it in bugzilla.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Brendan Gallagher 2016-04-01 19:09:56 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!
Comment 5 Julian Maurice 2016-04-07 08:19:37 UTC
Not needed in stable versions, status changed to RESOLVED