Bug 15355

Summary: Translatability: Fix issues on check in page
Product: Koha Reporter: Marc Véron <veron>
Component: I18N/L10NAssignee: Marc Véron <veron>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: brendan, f.demians, julian.maurice
Version: Main   
Hardware: All   
OS: All   
See Also: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14459
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15275
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15716
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 15693    
Attachments: Bug 15355: Translatability: Fix issues on check in page
Bug 15355: Translatability: Fix issues on check in page
Bug 15355: Translatability: Fix issues on check in page
[PASSED QA] Bug 15355: Translatability: Fix issues on check in page

Description Marc Véron 2015-12-11 17:01:48 UTC
Fix translatability issues on checkin page, due to sentence splitting by html tags at several places and ambiguous word 'to'.
Additionally, fix message related to syspref AllowReturnToBranch set to 'only the library where the item is checked out from' (it wrongly displays the home library instead of the holding library), and streamline the display of similar messages to look more consistent.
Comment 1 Marc Véron 2015-12-11 17:17:40 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2015-12-11 17:34:26 UTC Comment hidden (obsolete)
Comment 3 Aleisha Amohia 2015-12-21 21:34:38 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2016-01-06 20:24:43 UTC
Created attachment 46353 [details] [review]
[PASSED QA] Bug 15355: Translatability: Fix issues on check in page

This patch fixes translatability issues on checkin page, due to sentence splitting by html tags at
several places and ambiguous word 'to'.

Additionally, fix message related to syspref AllowReturnToBranch set to 'only the library where the
item is checked out from' (it wrongly displays the home library instead of the holding library),
and streamline the display of similar messages to look more consistent.

To test:
- Apply patch
- Go to Home > Circulation > Check in
- Do check ins with different expected results / messages
- Verify that the messages are meaningful and display nicely
- Play with items checked out / checked in at different branches (home branch, holding branch, other
  branch) and different settings for syspref 'AllowREturnToBranch' and verify that the messages display
  properly (with correct home rsp. holding branch)
- Carfully review code changes.

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Brendan Gallagher 2016-01-27 04:20:56 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!
Comment 6 Julian Maurice 2016-01-29 12:24:00 UTC
Patch pushed to 3.22.x, will be in 3.22.3