Bug 15355 - Translatability: Fix issues on check in page
Summary: Translatability: Fix issues on check in page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Marc Véron
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 15693
  Show dependency treegraph
 
Reported: 2015-12-11 17:01 UTC by Marc Véron
Modified: 2017-06-14 22:05 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15355: Translatability: Fix issues on check in page (12.22 KB, patch)
2015-12-11 17:17 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 15355: Translatability: Fix issues on check in page (12.78 KB, patch)
2015-12-11 17:34 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 15355: Translatability: Fix issues on check in page (12.83 KB, patch)
2015-12-21 21:34 UTC, Aleisha Amohia
Details | Diff | Splinter Review
[PASSED QA] Bug 15355: Translatability: Fix issues on check in page (12.90 KB, patch)
2016-01-06 20:24 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2015-12-11 17:01:48 UTC
Fix translatability issues on checkin page, due to sentence splitting by html tags at several places and ambiguous word 'to'.
Additionally, fix message related to syspref AllowReturnToBranch set to 'only the library where the item is checked out from' (it wrongly displays the home library instead of the holding library), and streamline the display of similar messages to look more consistent.
Comment 1 Marc Véron 2015-12-11 17:17:40 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2015-12-11 17:34:26 UTC Comment hidden (obsolete)
Comment 3 Aleisha Amohia 2015-12-21 21:34:38 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2016-01-06 20:24:43 UTC
Created attachment 46353 [details] [review]
[PASSED QA] Bug 15355: Translatability: Fix issues on check in page

This patch fixes translatability issues on checkin page, due to sentence splitting by html tags at
several places and ambiguous word 'to'.

Additionally, fix message related to syspref AllowReturnToBranch set to 'only the library where the
item is checked out from' (it wrongly displays the home library instead of the holding library),
and streamline the display of similar messages to look more consistent.

To test:
- Apply patch
- Go to Home > Circulation > Check in
- Do check ins with different expected results / messages
- Verify that the messages are meaningful and display nicely
- Play with items checked out / checked in at different branches (home branch, holding branch, other
  branch) and different settings for syspref 'AllowREturnToBranch' and verify that the messages display
  properly (with correct home rsp. holding branch)
- Carfully review code changes.

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Brendan Gallagher 2016-01-27 04:20:56 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!
Comment 6 Julian Maurice 2016-01-29 12:24:00 UTC
Patch pushed to 3.22.x, will be in 3.22.3