|
Description
Katrin Fischer
2015-12-29 10:04:25 UTC
Created attachment 46830 [details] [review] Bug 15436 Use semicolon between series name and volumne information To Test: Add 490 and 830 for series and volume View page Should be ; (Semicolon) between series name and volume information, this replaced the : that was used. Created attachment 46837 [details] [review] Bug 15436 Use semicolon between series name and volumne information To Test: Add 490 and 830 for series and volume View page Should be ; (Semicolon) between series name and volume information, this replaced the : that was used. This patch breaks the detail view for me (no bibliographic data appears). Errors in the log: Error while parsing stylesheet: compilation error: file /koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl element text xsltParseTemplateContent: xslt:text content problem This doesn't break for me, could someone else test and comment. Setting this back to Needs Signoff so someone else can test because it works fine for me. Created attachment 48695 [details]
opac broken
After applying this patch the OPAC display is completely broken.
Created attachment 48696 [details]
no difference in staff
And there is no difference in the staff.
This bug has been confusing us for a little while. Can you please clarify how to reproduce the bug, what fields should be filled? Hi Aleisha, I found an example in the kohadevboxsample data: Title: Scéla mucce Meic Dathó, 490 0 _aMediaeval and modern Irish series. _vvol. VI Displays as: Series: Mediaeval and modern Irish series. vol. VI. That should be: Series: Mediaeval and modern Irish series ; vol. VI. See: http://www.loc.gov/marc/bibliographic/bd490.html (you could also test catalog the examples given there) Antoher problem appears with the older 440: Title: Scarlet and black 440 0 _aPenguin readers. _pLevel 6 _9582 Displays as: Series: Penguin readersLevel 6. I'm not 100% sure that this is still a problem as reported - I don't see any punctuation between subfield a and v. Created attachment 110304 [details] [review] Bug 15436: Use semicolon between series name and volume MARC21 dictates that we should be using a ; before $v in 440, 490, 810, 811 and 830. This patch also introduces some additional changes to unify formatting between the various options for cataloguing series: - The separator between multiple series is switched form ; to the now commonly used | with a class for easy change of formatting. - There was some missing logic that prevented the separator to show up correctly between traced and untraced series. - For some series $v was included in the link for others not. Now $v always appears as text and only $a is linked, as this is what we actually search for. To test this: - You should be cataloguing multiple series in different ways, using - deprecated 440 (still present in old data) - 490, Ind. 1 = empty or 0 = not traced - 490, Ind. 1 = 1 = traced in combination with an 8xx field Example (you should try a different combination!) 440 _ _ $aFirst series 490 _ _ $aSecond series ;$v1 490 1 _ $aThird series ;$v1 (this won't show, it will use 830 for display) 830 _ _ $aThird series ;$v1 Without patch: Series: First Series; Second series ; 1Third series: 1 With patch: Series: First series | Second series ; 1 | Third series ; 1 David, hope you don't mind me stealing this one. The problem occurred only for traced series where the 8xx fields are used for display. Hi Katrin. I had a go at this, but don't feel confident enough to sign it off given my limited understanding of MARC21 nuances! Things I noticed: 1. For Scéla mucce Meic Dathó, (mentioned in comment 9): after the patch it displays as Mediaeval and modern Irish series ; vol. VI | <== there is a | and no . after the VI 2. For Scarlet and black (also mentioned in comment 9): I noticed no change after the patch was applied 3. For the example in the test plan: that displayed as expected (First series | Second series ; 1 | Third series ; 1) David Nind Hi David, first of all, thx for testing! > 1. For Scéla mucce Meic Dathó, (mentioned in comment 9): after the patch it > displays as Mediaeval and modern Irish series ; vol. VI | <== there is a | > and no . after the VI Good catch! I fixed this in staff, in OPAC it was already ok. > 2. For Scarlet and black (also mentioned in comment 9): I noticed no change > after the patch was applied This is kind of unrelated to the patch here - if you look at the record on master the problem appears there as well (missing space between 440a and p) The problem is that the part template used for displaying n and p is not adding any space or punctuation. I'd like to move that to a separate bug. Ok? > 3. For the example in the test plan: that displayed as expected (First > series | Second series ; 1 | Third series ; 1) > > David Nind Created attachment 110438 [details] [review] Bug 15436: (follow-up) Fix separators Created attachment 110439 [details] [review] Bug 15436: (follow-up) Fix separator for a single 440 in staff Created attachment 110480 [details] [review] Bug 15436: Use semicolon between series name and volume MARC21 dictates that we should be using a ; before $v in 440, 490, 810, 811 and 830. This patch also introduces some additional changes to unify formatting between the various options for cataloguing series: - The separator between multiple series is switched form ; to the now commonly used | with a class for easy change of formatting. - There was some missing logic that prevented the separator to show up correctly between traced and untraced series. - For some series $v was included in the link for others not. Now $v always appears as text and only $a is linked, as this is what we actually search for. To test this: - You should be cataloguing multiple series in different ways, using - deprecated 440 (still present in old data) - 490, Ind. 1 = empty or 0 = not traced - 490, Ind. 1 = 1 = traced in combination with an 8xx field Example (you should try a different combination!) 440 _ _ $aFirst series 490 _ _ $aSecond series ;$v1 490 1 _ $aThird series ;$v1 (this won't show, it will use 830 for display) 830 _ _ $aThird series ;$v1 Without patch: Series: First Series; Second series ; 1Third series: 1 With patch: Series: First series | Second series ; 1 | Third series ; 1 Signed-off-by: David Nind <david@davidnind.com> Created attachment 110481 [details] [review] Bug 15436: (follow-up) Fix separator for a single 440 in staff Signed-off-by: David Nind <david@davidnind.com> Created attachment 111356 [details] [review] Bug 15436: Use semicolon between series name and volume MARC21 dictates that we should be using a ; before $v in 440, 490, 810, 811 and 830. This patch also introduces some additional changes to unify formatting between the various options for cataloguing series: - The separator between multiple series is switched form ; to the now commonly used | with a class for easy change of formatting. - There was some missing logic that prevented the separator to show up correctly between traced and untraced series. - For some series $v was included in the link for others not. Now $v always appears as text and only $a is linked, as this is what we actually search for. To test this: - You should be cataloguing multiple series in different ways, using - deprecated 440 (still present in old data) - 490, Ind. 1 = empty or 0 = not traced - 490, Ind. 1 = 1 = traced in combination with an 8xx field Example (you should try a different combination!) 440 _ _ $aFirst series 490 _ _ $aSecond series ;$v1 490 1 _ $aThird series ;$v1 (this won't show, it will use 830 for display) 830 _ _ $aThird series ;$v1 Without patch: Series: First Series; Second series ; 1Third series: 1 With patch: Series: First series | Second series ; 1 | Third series ; 1 Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 111357 [details] [review] Bug 15436: (follow-up) Fix separator for a single 440 in staff Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 20.11, thanks to everybody involved! enhancement will not be backported to 20.05.x |