|
Description
Nicole C. Engard
2016-01-06 16:36:02 UTC
We are a large consortium -- this would definitely be of benefit to us. http://devs.bywatersolutions.com/2016/11/30/Limit-Item-Types-by-Branch/ According to the updated dev site on Bywater it looks like this has been funded. Lisette +1 Created attachment 91377 [details] [review] Bug 15497: Add itemtypes_branches table and atomic update Created attachment 91378 [details] [review] Bug 15497: Modify schemas Created attachment 91379 [details] [review] Bug 15497: Limit itemtypes by branch in additem.pl This patch adds a select multiple when you add/edit an itemtype, creates functions to return itemtypes by library, and filters the options of itemtype select in additem To test: 1) Apply this patch set 2) perl installer/data/mysql/updatedatabase.pl 3) In koha administration => item types, edit "Books" itemtype CHECK => there is now a select multiple whith libraries at the bottom 4) select centerville and save 5) set centerville as current libary 6) search for any biblio in the catalog 7) click on "edit items" CHECK => book item type is present 8) set any other libary as current library SUCCESS => book item type is not present 9) Sign off Created attachment 91446 [details] [review] Bug 15497: Remove use of Data::Printer When testing, I get to Administration > Itemtypes> Edit > select Centerville > Save and I get the following error Undefined subroutine &CGI::Compile::ROOT::kohadevbox_koha_admin_itemtypes_2epl::p called at /kohadevbox/koha/admin/itemtypes.pl line 202. at /kohadevbox/koha/admin/itemtypes.pl line 201 Created attachment 91450 [details] [review] Bug 15497: Add itemtypes_branches table and atomic update Created attachment 91451 [details] [review] Bug 15497: Modify schemas Created attachment 91452 [details] [review] Bug 15497: Limit itemtypes by branch in additem.pl This patch adds a select multiple when you add/edit an itemtype, creates functions to return itemtypes by library, and filters the options of itemtype select in additem To test: 1) Apply this patch set 2) perl installer/data/mysql/updatedatabase.pl 3) In koha administration => item types, edit "Books" itemtype CHECK => there is now a select multiple whith libraries at the bottom 4) select centerville and save 5) set centerville as current libary 6) search for any biblio in the catalog 7) click on "edit items" CHECK => book item type is present 8) set any other libary as current library SUCCESS => book item type is not present 9) Sign off (In reply to Jessie Zairo from comment #8) > When testing, I get to Administration > Itemtypes> Edit > select Centerville > > Save and I get the following error > > Undefined subroutine > &CGI::Compile::ROOT::kohadevbox_koha_admin_itemtypes_2epl::p called at > /kohadevbox/koha/admin/itemtypes.pl line 202. > at /kohadevbox/koha/admin/itemtypes.pl line 201 Sorry, my bad.. forgot to cleanup debug statements. Please try again Created attachment 91469 [details] [review] Bug 15497: Limit itemtypes by branch in additem.pl This patch adds a select multiple when you add/edit an itemtype, creates functions to return itemtypes by library, and filters the options of itemtype select in additem To test: 1) Apply this patch set 2) perl installer/data/mysql/updatedatabase.pl 3) In koha administration => item types, edit "Books" itemtype CHECK => there is now a select multiple whith libraries at the bottom 4) select centerville and save 5) set centerville as current libary 6) search for any biblio in the catalog 7) click on "edit items" CHECK => book item type is present 8) set any other libary as current library SUCCESS => book item type is not present 9) Sign off Signed-off-by: Jessica Zairo <jzairo@bywatersolutions.com> I think this shoudl depend on bug 23281? +use base qw(Koha::Object Koha::Object::Limit::Library); Created attachment 92725 [details] [review] Bug 15497: Add itemtypes_branches table and atomic update Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 92726 [details] [review] Bug 15497: Modify schemas Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 92727 [details] [review] Bug 15497: Limit itemtypes by branch in additem.pl This patch adds a select multiple when you add/edit an itemtype, creates functions to return itemtypes by library, and filters the options of itemtype select in additem To test: 1) Apply this patch set 2) perl installer/data/mysql/updatedatabase.pl 3) In koha administration => item types, edit "Books" itemtype CHECK => there is now a select multiple whith libraries at the bottom 4) select centerville and save 5) set centerville as current libary 6) search for any biblio in the catalog 7) click on "edit items" CHECK => book item type is present 8) set any other libary as current library SUCCESS => book item type is not present 9) Sign off Signed-off-by: Jessica Zairo <jzairo@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 92728 [details] [review] Bug 15497: (QA follow-up) Use the methods from bug 23281 instead Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> (In reply to Katrin Fischer from comment #14) > I think this shoudl depend on bug 23281? > > +use base qw(Koha::Object Koha::Object::Limit::Library); That was correct boss, it is just that Agustin wrote this and then I realized we had to have 23281 and stop repeating code. Thanks for pointing it out! Created attachment 92732 [details] [review] Bug 15497: (QA follow-up) Fix call in search_with_localization Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 92735 [details] [review] Bug 15497: Add itemtypes_branches table and atomic update Signed-off-by: Jessica Zairo <jzairo@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 92736 [details] [review] Bug 15497: Modify schemas Signed-off-by: Jessica Zairo <jzairo@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 92737 [details] [review] Bug 15497: Limit itemtypes by branch in additem.pl This patch adds a select multiple when you add/edit an itemtype, creates functions to return itemtypes by library, and filters the options of itemtype select in additem To test: 1) Apply this patch set 2) perl installer/data/mysql/updatedatabase.pl 3) In koha administration => item types, edit "Books" itemtype CHECK => there is now a select multiple whith libraries at the bottom 4) select centerville and save 5) set centerville as current libary 6) search for any biblio in the catalog 7) click on "edit items" CHECK => book item type is present 8) set any other libary as current library SUCCESS => book item type is not present 9) Sign off Signed-off-by: Jessica Zairo <jzairo@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 92738 [details] [review] Bug 15497: (QA follow-up) Use the methods from bug 23281 instead Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 92739 [details] [review] Bug 15497: (QA follow-up) Fix call in search_with_localization Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> All works well for me and passes QA scripts... No obvious regressions. Passing QA. Some minor additions in the future might be nice.. there's nothing that ties this in at the circ rules level.. one can still create a circ rule at any branch with any itemtype for example and there's nothing to prevent an item being permanently transferred to the branch without that itemtype and as such you end up with an incorrectly types item at that branch. I don't see either of the above as failure points, but perhaps worth mentioning and perhaps a followup bug creating to document these shortcomings. (In reply to Martin Renvoize from comment #26) > All works well for me and passes QA scripts... No obvious regressions. > > Passing QA. Thanks! > Some minor additions in the future might be nice.. there's nothing that ties > this in at the circ rules level.. one can still create a circ rule at any > branch with any itemtype for example and there's nothing to prevent an item > being permanently transferred to the branch without that itemtype and as > such you end up with an incorrectly types item at that branch. > > I don't see either of the above as failure points, but perhaps worth > mentioning and perhaps a followup bug creating to document these > shortcomings. I'm sure the consortia that sponsored this dev will have interesting additions and requests to make now that this is in master and can have a real-life test drive! Created attachment 92741 [details] [review] Bug 15497: Add itemtypes_branches table and atomic update Sponsored-by: Northeast Kansas Library System Sponsored-by: Southeast Kansas Library System Sponsored-by: Central Kansas Library System Signed-off-by: Jessica Zairo <jzairo@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 92742 [details] [review] Bug 15497: Modify schemas Sponsored-by: Northeast Kansas Library System Sponsored-by: Southeast Kansas Library System Sponsored-by: Central Kansas Library System Signed-off-by: Jessica Zairo <jzairo@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 92743 [details] [review] Bug 15497: Limit itemtypes by branch in additem.pl This patch adds a select multiple when you add/edit an itemtype, creates functions to return itemtypes by library, and filters the options of itemtype select in additem To test: 1) Apply this patch set 2) perl installer/data/mysql/updatedatabase.pl 3) In koha administration => item types, edit "Books" itemtype CHECK => there is now a select multiple whith libraries at the bottom 4) select centerville and save 5) set centerville as current libary 6) search for any biblio in the catalog 7) click on "edit items" CHECK => book item type is present 8) set any other libary as current library SUCCESS => book item type is not present 9) Sign off Sponsored-by: Northeast Kansas Library System Sponsored-by: Southeast Kansas Library System Sponsored-by: Central Kansas Library System Signed-off-by: Jessica Zairo <jzairo@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 92744 [details] [review] Bug 15497: (QA follow-up) Use the methods from bug 23281 instead Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 92745 [details] [review] Bug 15497: (QA follow-up) Fix call in search_with_localization Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Sponsor lines moved into commit message so they're caught by the release notes script. Thankyou Northeast Kansas Library System, Southeast Kansas Library System and Central Kansas Library System. Nice work! Pushed to master for 19.11.00 Enhancement not pushed to 19.05.x
> > Some minor additions in the future might be nice.. there's nothing that ties
> > this in at the circ rules level.. one can still create a circ rule at any
> > branch with any itemtype for example and there's nothing to prevent an item
> > being permanently transferred to the branch without that itemtype and as
> > such you end up with an incorrectly types item at that branch.
> >
> > I don't see either of the above as failure points, but perhaps worth
> > mentioning and perhaps a followup bug creating to document these
> > shortcomings.
>
> I'm sure the consortia that sponsored this dev will have interesting
> additions and requests to make now that this is in master and can have a
> real-life test drive!
I think both those might be desirable behaviour for some workflows, so happy to see what's to come too :)
Added release notes and manual patch (in gitlab). |