| Summary: | Update API to allow multiple holds for the same record | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Julian Maurice <julian.maurice> |
| Component: | Web services | Assignee: | Alex Arnaud <alex.arnaud> |
| Status: | BLOCKED --- | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | alex.arnaud, arthur.suzuki, benjamin.rokseth, dcook, lisette, m.de.rooy |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 13903, 14695, 15565 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 15567 - Allow to place multiple at once via RESTFUL
Bug 15567 - Allow to place multiple at once via RESTFUL |
||
|
Description
Julian Maurice
2016-01-13 13:23:34 UTC
Created attachment 47860 [details] [review] Bug 15567 - Allow to place multiple at once via RESTFUL Test plan: Same tests than Bug 15565 but via RESTFUL Created attachment 50083 [details] [review] Bug 15567 - Allow to place multiple at once via RESTFUL Test plan: Same tests than Bug 15565 but via RESTFUL Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> Rebased against master. Tested OK, but should avait dependent bugs 14695 and 15565 This looks like it should be marked "Signed off." Please change it if I'm wrong. Depends on a FQA Not sure why this would depend on bug 15565... Looks like this patch adds way too much logic into the controller. Surely it would make sense to just take multiple items in as input and then run it through a loop and record the results. If we have the API endpoint, then maybe we can change the UIs to use the API and sidestep even needing 15565 as it stands (In reply to David Cook from comment #6) > Surely it would make sense to just take multiple items in as input and then > run it through a loop and record the results. I mean I've created my own API endpoint in a different system which takes data for multiple items and does exactly that, so that 1 API call on that system can place holds for multiple items at the same time. (It's just the backend API call to the Koha that has to be done X times.) to be honest I don't really see the point of having a client software pushing a "batch" of holds to Koha. That could as well be handled by the client (portal) software in a for-loop to make a single request for each hold request. IMO that kind of handling should be done on the client software rather than Koha. Also there are already portal software in the wild (like Aspen or VuFind) which are using the holds api, and that patch would break compatibility with them. Best, Arthur |