Bug 15567 - Update API to allow multiple holds for the same record
Summary: Update API to allow multiple holds for the same record
Status: BLOCKED
Alias: None
Product: Koha
Classification: Unclassified
Component: Web services (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Alex Arnaud
QA Contact: Testopia
URL:
Keywords:
Depends on: 13903 14695 15565
Blocks:
  Show dependency tree / graph
 
Reported: 2016-01-13 13:23 UTC by Julian Maurice
Modified: 2023-05-23 23:40 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 15567 - Allow to place multiple at once via RESTFUL (13.91 KB, patch)
2016-02-10 16:49 UTC, Alex Arnaud 		Details | Diff | Splinter Review
Bug 15567 - Allow to place multiple at once via RESTFUL (14.03 KB, patch)
2016-04-08 13:43 UTC, Benjamin Rokseth 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Maurice 2016-01-13 13:23:34 UTC 
Bug 14695 and bug 15565 will allow to place multiple holds for the same record. The API should allow that too.
Comment 1 Alex Arnaud 2016-02-10 16:49:52 UTC Comment hidden (obsolete)
Comment 2 Benjamin Rokseth 2016-04-08 13:43:19 UTC 
Created attachment 50083 [details] [review]
Bug 15567 - Allow to place multiple at once via RESTFUL

Test plan:
Same tests than Bug 15565 but via RESTFUL

Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no>
Comment 3 Benjamin Rokseth 2016-04-08 13:44:59 UTC 
Rebased against master.
Tested OK, but should avait dependent bugs 14695 and 15565
Comment 4 Owen Leonard 2017-04-10 16:54:45 UTC 
This looks like it should be marked "Signed off." Please change it if I'm wrong.
Comment 5 Marcel de Rooy 2017-06-16 10:15:40 UTC 
Depends on a FQA
Comment 6 David Cook 2023-05-23 23:39:25 UTC 
Not sure why this would depend on bug 15565... 

Looks like this patch adds way too much logic into the controller.

Surely it would make sense to just take multiple items in as input and then run it through a loop and record the results. 

If we have the API endpoint, then maybe we can change the UIs to use the API and sidestep even needing 15565 as it stands
Comment 7 David Cook 2023-05-23 23:40:42 UTC 
(In reply to David Cook from comment #6)
> Surely it would make sense to just take multiple items in as input and then
> run it through a loop and record the results. 

I mean I've created my own API endpoint in a different system which takes data for multiple items and does exactly that, so that 1 API call on that system can place holds for multiple items at the same time. (It's just the backend API call to the Koha that has to be done X times.)