Summary: | Remove use of recordpayment_selectaccts | ||
---|---|---|---|
Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
Component: | Architecture, internals, and plumbing | Assignee: | Kyle M Hall (khall) <kyle> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | veron |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 15909 | ||
Bug Blocks: | 15894, 19205 | ||
Attachments: |
Bug 15908 - Remove use of recordpayment_selectaccts
Bug 15908 - Remove use of recordpayment_selectaccts Bug 15908 - Remove use of recordpayment_selectaccts Bug 15908 - Remove use of recordpayment_selectaccts Bug 15908 - Remove use of recordpayment_selectaccts Bug 15908 - Remove use of recordpayment_selectaccts Bug 15908 - Remove use of recordpayment_selectaccts |
Description
Kyle M Hall (khall)
2016-02-24 16:15:12 UTC
Created attachment 48352 [details] [review] Bug 15908 - Remove use of recordpayment_selectaccts Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay selected" button I get the following on current master: Applying: Bug 15908 - Remove use of recordpayment_selectaccts fatal: sha1 information is lacking or useless (C4/Accounts.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 15908 - Remove use of recordpayment_selectaccts Created attachment 52134 [details] [review] Bug 15908 - Remove use of recordpayment_selectaccts Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay selected" button Created attachment 52152 [details] [review] Bug 15908 - Remove use of recordpayment_selectaccts Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay selected" button Comment on attachment 52152 [details] [review] Bug 15908 - Remove use of recordpayment_selectaccts Review of attachment 52152 [details] [review]: ----------------------------------------------------------------- Perhaps it is an extra constraint, but the code isn't identical without it. Results should be identical though. ::: C4/Accounts.pm @@ -372,5 @@ > - > - my @lines = Koha::Account::Lines->search( > - { > - borrowernumber => $borrowernumber, > - amountoutstanding => { '<>' => 0 }, Why is... ::: members/paycollect.pl @@ +135,5 @@ > + > + my @lines = Koha::Account::Lines->search( > + { > + borrowernumber => $borrowernumber, > + accountno => { 'IN' => \@acc }, ... this not here? Created attachment 58752 [details] [review] Bug 15908 - Remove use of recordpayment_selectaccts Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay selected" button Created attachment 58754 [details] [review] Bug 15908 - Remove use of recordpayment_selectaccts Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay selected" button Created attachment 58755 [details] [review] Bug 15908 - Remove use of recordpayment_selectaccts Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay selected" button Signed-off-by: Laura Slavin <lslavin@hmcpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 58767 [details] [review] Bug 15908 - Remove use of recordpayment_selectaccts Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay selected" button Signed-off-by: Laura Slavin <lslavin@hmcpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 17.05! This won't get ported back to 16.11.x as it is an enhancement. |