|
Description
Aleisha Amohia
2016-03-03 02:26:55 UTC
Created attachment 48710 [details] [review] Bug 15966: Move MARC frameworks actions into a drop down menu To test: 1) Go to Administration -> MARC bibliographic framework (admin/biblio_framework.pl) 2) Confirm that all actions have now been moved into drop down menus. a) For Default framework, actions available are 'MARC structure', 'Export' and 'Import'. b) Confirm these buttons all work as expected. c) For all other frameworks, actions available are 'MARC structure', 'Edit', 'Delete', 'Export' and 'Import'. d) Confirm these buttons all work as expected. Sponsored-by: Catalyst IT Created attachment 48716 [details] [review] Bug 15966: Move MARC frameworks actions into a drop down menu To test: 1) Go to Administration -> MARC bibliographic framework (admin/biblio_framework.pl) 2) Confirm that all actions have now been moved into drop down menus. a) For Default framework, actions available are 'MARC structure', 'Export' and 'Import'. b) Confirm these buttons all work as expected. c) For all other frameworks, actions available are 'MARC structure', 'Edit', 'Delete', 'Export' and 'Import'. d) Confirm these buttons all work as expected. Sponsored-by: Catalyst IT Created attachment 48822 [details] [review] Bug 15966: Move MARC frameworks actions into a drop down menu To test: 1) Go to Administration -> MARC bibliographic framework (admin/biblio_framework.pl) 2) Confirm that all actions have now been moved into drop down menus. a) For Default framework, actions available are 'MARC structure', 'Export' and 'Import'. b) Confirm these buttons all work as expected. c) For all other frameworks, actions available are 'MARC structure', 'Edit', 'Delete', 'Export' and 'Import'. d) Confirm these buttons all work as expected. Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> I am wondering if the import and export icon buttons are not inverted, please confirm it's what you want. I agree with Jonathan, I think they are reversed. Created attachment 48899 [details] [review] Bug 15966: Move MARC frameworks actions into a drop down menu EDIT: Switching icons for Export and Import. What I had initially was what I intended because export is like downloading and import is like upload, but it seems to make more sense reversed. To test: 1) Go to Administration -> MARC bibliographic framework (admin/biblio_framework.pl) 2) Confirm that all actions have now been moved into drop down menus. a) For Default framework, actions available are 'MARC structure', 'Export' and 'Import'. b) Confirm these buttons all work as expected. c) For all other frameworks, actions available are 'MARC structure', 'Edit', 'Delete', 'Export' and 'Import'. d) Confirm these buttons all work as expected. Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> Import was complaining I didn't select a CSV file, when I had. P.S. Export worked for CSV, so I suspect all is good for Export. Other links worked too. Just import failed. Created attachment 48911 [details] [review] Bug 15966: Move MARC frameworks actions into a drop down menu EDIT: Switching icons for Export and Import. What I had initially was what I intended because export is like downloading and import is like upload, but it seems to make more sense reversed. EDIT2: Fixing Import problem To test: 1) Go to Administration -> MARC bibliographic framework (admin/biblio_framework.pl) 2) Confirm that all actions have now been moved into drop down menus. a) For Default framework, actions available are 'MARC structure', 'Export' and 'Import'. b) Confirm these buttons all work as expected. c) For all other frameworks, actions available are 'MARC structure', 'Edit', 'Delete', 'Export' and 'Import'. d) Confirm these buttons all work as expected. Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> Comment on attachment 48911 [details] [review] Bug 15966: Move MARC frameworks actions into a drop down menu Review of attachment 48911 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tt @@ +63,4 @@ > $('form.form_import').submit(function() { > var id = $(this).attr('id'); > var obj = $('#' + id + ' input:file'); > + alert(obj.val()); Oops. Forgot to remove debugging line. Created attachment 48913 [details] [review] Bug 15966: Move MARC frameworks actions into a drop down menu EDIT: Switching icons for Export and Import. What I had initially was what I intended because export is like downloading and import is like upload, but it seems to make more sense reversed. EDIT2: Fixing Import problem To test: 1) Go to Administration -> MARC bibliographic framework (admin/biblio_framework.pl) 2) Confirm that all actions have now been moved into drop down menus. a) For Default framework, actions available are 'MARC structure', 'Export' and 'Import'. b) Confirm these buttons all work as expected. c) For all other frameworks, actions available are 'MARC structure', 'Edit', 'Delete', 'Export' and 'Import'. d) Confirm these buttons all work as expected. Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> Created attachment 48914 [details] [review] Bug 15966: Move MARC frameworks actions into a drop down menu EDIT: Switching icons for Export and Import. What I had initially was what I intended because export is like downloading and import is like upload, but it seems to make more sense reversed. EDIT2: Fixing Import problem To test: 1) Go to Administration -> MARC bibliographic framework (admin/biblio_framework.pl) 2) Confirm that all actions have now been moved into drop down menus. a) For Default framework, actions available are 'MARC structure', 'Export' and 'Import'. b) Confirm these buttons all work as expected. c) For all other frameworks, actions available are 'MARC structure', 'Edit', 'Delete', 'Export' and 'Import'. d) Confirm these buttons all work as expected. Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 48951 [details] [review] Bug 15966: Move MARC frameworks actions into a drop down menu EDIT: Switching icons for Export and Import. What I had initially was what I intended because export is like downloading and import is like upload, but it seems to make more sense reversed. EDIT2: Fixing Import problem To test: 1) Go to Administration -> MARC bibliographic framework (admin/biblio_framework.pl) 2) Confirm that all actions have now been moved into drop down menus. a) For Default framework, actions available are 'MARC structure', 'Export' and 'Import'. b) Confirm these buttons all work as expected. c) For all other frameworks, actions available are 'MARC structure', 'Edit', 'Delete', 'Export' and 'Import'. d) Confirm these buttons all work as expected. Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - Should be in the May 2016 release. Thanks! |