Bug 15966 - Move MARC frameworks actions into a drop down menu
Summary: Move MARC frameworks actions into a drop down menu
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-03 02:26 UTC by Aleisha Amohia
Modified: 2017-06-14 22:10 UTC (History)
4 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15966: Move MARC frameworks actions into a drop down menu (20.20 KB, patch)
2016-03-06 21:38 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15966: Move MARC frameworks actions into a drop down menu (20.20 KB, patch)
2016-03-06 22:18 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15966: Move MARC frameworks actions into a drop down menu (20.26 KB, patch)
2016-03-08 20:45 UTC, Nicole C. Engard
Details | Diff | Splinter Review
Bug 15966: Move MARC frameworks actions into a drop down menu (20.45 KB, patch)
2016-03-10 01:33 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15966: Move MARC frameworks actions into a drop down menu (21.08 KB, patch)
2016-03-10 03:08 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15966: Move MARC frameworks actions into a drop down menu (20.52 KB, patch)
2016-03-10 03:21 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15966: Move MARC frameworks actions into a drop down menu (20.57 KB, patch)
2016-03-10 03:27 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 15966: Move MARC frameworks actions into a drop down menu (20.64 KB, patch)
2016-03-10 12:28 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2016-03-03 02:26:55 UTC
Similar to Bug 15932, Bug 13778, Bug 15830, Bug 15952
Comment 1 Aleisha Amohia 2016-03-06 21:38:16 UTC Comment hidden (obsolete)
Comment 2 Aleisha Amohia 2016-03-06 22:18:11 UTC Comment hidden (obsolete)
Comment 3 Nicole C. Engard 2016-03-08 20:45:09 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2016-03-09 11:45:11 UTC
I am wondering if the import and export icon buttons are not inverted, please confirm it's what you want.
Comment 5 Owen Leonard 2016-03-09 12:58:08 UTC
I agree with Jonathan, I think they are reversed.
Comment 6 Aleisha Amohia 2016-03-10 01:33:14 UTC Comment hidden (obsolete)
Comment 7 Mark Tompsett 2016-03-10 01:47:56 UTC
Import was complaining I didn't select a CSV file, when I had.
Comment 8 Mark Tompsett 2016-03-10 01:48:58 UTC
P.S. Export worked for CSV, so I suspect all is good for Export. Other links worked too. Just import failed.
Comment 9 Aleisha Amohia 2016-03-10 03:08:05 UTC Comment hidden (obsolete)
Comment 10 Mark Tompsett 2016-03-10 03:16:56 UTC
Comment on attachment 48911 [details] [review]
Bug 15966: Move MARC frameworks actions into a drop down menu

Review of attachment 48911 [details] [review]:
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tt
@@ +63,4 @@
>          $('form.form_import').submit(function() {
>              var id = $(this).attr('id');
>              var obj = $('#' + id + ' input:file');
> +            alert(obj.val());

Oops. Forgot to remove debugging line.
Comment 11 Aleisha Amohia 2016-03-10 03:21:30 UTC Comment hidden (obsolete)
Comment 12 Mark Tompsett 2016-03-10 03:27:05 UTC Comment hidden (obsolete)
Comment 13 Jonathan Druart 2016-03-10 12:28:20 UTC
Created attachment 48951 [details] [review]
Bug 15966: Move MARC frameworks actions into a drop down menu

EDIT: Switching icons for Export and Import. What I had initially was what I intended because export is like downloading and import is like upload, but it seems to make more sense reversed.
EDIT2: Fixing Import problem

To test:

1) Go to Administration -> MARC bibliographic framework (admin/biblio_framework.pl)
2) Confirm that all actions have now been moved into drop down menus.
  a) For Default framework, actions available are 'MARC structure', 'Export' and 'Import'.
  b) Confirm these buttons all work as expected.
  c) For all other frameworks, actions available are 'MARC structure', 'Edit', 'Delete', 'Export' and 'Import'.
  d) Confirm these buttons all work as expected.

Sponsored-by: Catalyst IT

Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com>

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 14 Brendan Gallagher 2016-03-12 23:33:03 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!