Description
Aleisha Amohia
2016-03-06 22:11:37 UTC
Created attachment 48713 [details] [review] Bug 15990: Moving record matching rules actions into a drop-down menu To test: 1) Go to Administration -> Record matching rules 2) Confirm that the actions 'Edit' and 'Delete' have been moved into a drop-down menu and buttons behave as expected. Sponsored-by: Catalyst IT I think we should not make dropdowns where there are only two options. I would like to propose that we start using Bootstrap-styled buttons like this when there are only two links: <a class="btn btn-mini" href="[% available_matching_rule.script_name %]?op=edit_matching_rule&matcher_id=[% available_matching_rule.matcher_id |html %]"><i class="fa fa-pencil"></i> Edit</a> <a class="btn btn-mini" href="[% available_matching_rule.script_name %]?op=delete_matching_rule&matcher_id=[% available_matching_rule.matcher_id |html %]"><i class="fa fa-remove"></i> Delete</a> The pull down adds another click - so in cases with not so many options I think the buttons could work nicely. Created attachment 48821 [details] [review] Bug 15990: Moving record matching rules actions into a drop-down menu To test: 1) Go to Administration -> Record matching rules 2) Confirm that the actions 'Edit' and 'Delete' have been moved into a drop-down menu and buttons behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> Created attachment 48848 [details] [review] Bug 15990: Moving record matching rules actions into a drop-down menu To test: 1) Go to Administration -> Record matching rules 2) Confirm that the actions 'Edit' and 'Delete' have been moved into a drop-down menu and buttons behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Aleisha, putting this in discussion, it seems that we should use the drop-down menu only when we have more than 2 buttons. Created attachment 48902 [details] [review] Bug 15990: Making record matching rules actions buttons To test: 1) Go to Administration -> Record matching rules 2) Confirm that the actions 'Edit' and 'Delete' are not buttons and behave as expected. Sponsored-by: Catalyst IT Created attachment 49057 [details] [review] [SIGNED-OFF] Bug 15990: Making record matching rules actions buttons To test: 1) Go to Administration -> Record matching rules 2) Confirm that the actions 'Edit' and 'Delete' are not buttons and behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 49124 [details] [review] Bug 15990: Making record matching rules actions buttons To test: 1) Go to Administration -> Record matching rules 2) Confirm that the actions 'Edit' and 'Delete' are not buttons and behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 49125 [details] [review] Bug 15990: (follow-up) Making record matching rules actions buttons Adds the actions class to the td elt to keep the buttons next to each other. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - Should be in the May 2016 Release. Thanks! |