| Summary: | guarantor section missing ID on patron add form | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | brendan, chris, jonathan.druart, julian.maurice, veron |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15928 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7540 |
||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
code
Bug 16159 - guarantor section missing ID on patron add form Bug 16159 - guarantor section missing ID on patron add form Bug 16159 - guarantor section missing ID on patron add form |
||
Could you please detail what is the bug? Is it related to bug 15928? Created attachment 51164 [details] [review] Bug 16159 - guarantor section missing ID on patron add form In the patron entry form template most <fieldset> and <legend> tags have unique ids. This patch adds ids to fieldsets and legends which lack them. To test apply the patch and view the patron entry form. There should be no visual changes. There should be no HTML validation errors triggered by this change. Created attachment 51178 [details] [review] Bug 16159 - guarantor section missing ID on patron add form In the patron entry form template most <fieldset> and <legend> tags have unique ids. This patch adds ids to fieldsets and legends which lack them. To test apply the patch and view the patron entry form. There should be no visual changes. There should be no HTML validation errors triggered by this change. Signed-off-by: Marc Véron <veron@veron.ch> Why do we need an id on the legend elements? (In reply to Jonathan Druart from comment #4) > Why do we need an id on the legend elements? I don't know. I assume that the IDs were added at some time in the past in order to facilitate some kind of customization. My patch simply makes them consistent. (In reply to Owen Leonard from comment #5) > (In reply to Jonathan Druart from comment #4) > > Why do we need an id on the legend elements? > > I don't know. I assume that the IDs were added at some time in the past in > order to facilitate some kind of customization. My patch simply makes them > consistent. Added by bug 7540. Created attachment 51208 [details] [review] Bug 16159 - guarantor section missing ID on patron add form In the patron entry form template most <fieldset> and <legend> tags have unique ids. This patch adds ids to fieldsets and legends which lack them. To test apply the patch and view the patron entry form. There should be no visual changes. There should be no HTML validation errors triggered by this change. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - Should be in the May 2016 Release. Thanks! Patch pushed to 3.22.x, will be in 3.22.7 Pushed to 3.20.x will be in 3.20.11 |
Created attachment 49645 [details] code See attached. The Guarantor section doesn't have an ID.