Currently you can enter info for a guarantor without linking it to an account, however, you cannot see this info on the details page. If we can save it, we should show it.
Created attachment 48414 [details] [review] Bug 15928 - Show unlinked guarantor To test: 1 - Add guarantor data to patron account 2 - Note it is not displayed on patorn details 3 - Apply patch 4 - Note the info is displayed 5 - Test with combos of firstname/surname individually, you should see either but only a comma if both are present
I can see the improvement with your patch, but isn't it a bug in the first place? Shouldn't the guarantor Surname/Firstname data entry be blocked?
Some libraries use this currently for patrons whose guarantor doesn't have a card. It lets them have a record of the name of a responsible party and I think removing this ability would be a loss. I also think these fields can be used for organisation/affiliation when there may not be an account but still allows for grouping patrons.
I think that condition would benefit greatly if written as: [% IF ( guarantorborrowernumber ) %] ... [% ELSIF (guarantorsurname || guarantorfirstname) %] ... [% END %]
(In reply to Srdjan Jankovic from comment #4) > I think that condition would benefit greatly if written as: > [% IF ( guarantorborrowernumber ) %] > ... > [% ELSIF (guarantorsurname || guarantorfirstname) %] > ... > [% END %] Agreed.
Created attachment 49598 [details] [review] Bug 15928 - Show unlinked guarantor To test: 1 - Add guarantor data to patron account 2 - Note it is not displayed on patron details 3 - Apply patch 4 - Note the info is displayed 5 - Test that linked guarantors show as expected
Created attachment 49599 [details] [review] Bug 15928 - Show unlinked guarantor To test: 1 - Add guarantor data to patron account by typing it in but do not 'Set to patron' 2 - Note it is not displayed on patron details 3 - Apply patch 4 - Note the info is displayed 5 - Test that linked guarantors show as expected
Created attachment 49848 [details] [review] Bug 15928 - Show unlinked guarantor To test: 1 - Add guarantor data to patron account by typing it in but do not 'Set to patron' 2 - Note it is not displayed on patron details 3 - Apply patch 4 - Note the info is displayed 5 - Test that linked guarantors show as expected Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Amended-patch: Correct some indents/spaces
Pushed to Master - Should be in the May 2016 Release. Thanks!
Created attachment 50234 [details] [review] [3.22.x] Bug 15928 - Show unlinked guarantor Patch for 3.22.x
Patch pushed to 3.22.x, will be in 3.22.6
Pushed to 3.22.x, will be in 3.20.11.