Bug 7540 - Add ids to the legend elements to make it easier to tweak with javascript
Summary: Add ids to the legend elements to make it easier to tweak with javascript
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: 3.6
Hardware: All All
: P5 - low minor (vote)
Assignee: Robin Sheat
QA Contact: Ian Walls
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-14 23:25 UTC by Robin Sheat
Modified: 2016-05-04 16:26 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 7540 - add id values to the legends in the patron entry form (4.54 KB, patch)
2012-02-14 23:37 UTC, Robin Sheat
Details | Diff | Splinter Review
Bug 7540 [3.6.x] - add id values to the legends in the patron entry form (3.95 KB, patch)
2012-02-14 23:47 UTC, Robin Sheat
Details | Diff | Splinter Review
Bug 7540 - add id values to the legends in the patron entry form (4.69 KB, patch)
2012-02-16 04:22 UTC, Liz Rea
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Sheat 2012-02-14 23:25:30 UTC
This adds some IDs to the legends to make them easier to alter without customising templates.
Comment 1 Robin Sheat 2012-02-14 23:37:47 UTC Comment hidden (obsolete)
Comment 2 Robin Sheat 2012-02-14 23:47:40 UTC
Created attachment 7649 [details] [review]
Bug 7540 [3.6.x] - add id values to the legends in the patron entry form

This adds the following IDs to the legends in the patron entry form:
 main_address_lgd contact_lgd alt_address_lgd alt_contact_lgd
 library_management_lgd library_setup_lgd opac_staff_login_lgd
 patron_messaging_prefs_lgd

With these in place, then jquery like:
$(document).ready(function(){
        $('#main_address_lgd').text('Postal Address');
        $('#alt_address_lgd').text('Residential Address');
});
in intranetuserjs can be used to rename things to taste.
Comment 3 Liz Rea 2012-02-16 04:22:28 UTC
Created attachment 7675 [details] [review]
Bug 7540 - add id values to the legends in the patron entry form

This adds the following IDs to the legends in the patron entry form:
 main_address_lgd contact_lgd alt_address_lgd alt_contact_lgd
 library_management_lgd library_setup_lgd opac_staff_login_lgd
 patron_messaging_prefs_lgd

With these in place, then jquery like:
$(document).ready(function(){
        $('#main_address_lgd').text('Postal Address');
        $('#alt_address_lgd').text('Residential Address');
});
in intranetuserjs can be used to rename things to taste.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
I see the id's in there, they appear consistent and complete.
Comment 4 Ian Walls 2012-02-16 17:06:21 UTC
Template only change to add unique ID attributes to elements (always a good thing).  Marking as Passed QA.
Comment 5 Paul Poulain 2012-02-17 10:55:28 UTC
changed importance to "minor", it's not really an ENH.
chris_n, there is a 3.6 patch for this one
Comment 6 Jared Camins-Esakov 2012-05-23 23:14:55 UTC
This patch will be included in the upcoming 3.6.5 release.