Description
Owen Leonard
2016-05-18 16:39:14 UTC
Created attachment 51788 [details] [review] Bug 16546 - Make edit and delete links styled buttons in MARC bibliographic framework administration This patch modifies two MARC framwork templates, styling some edit and delete links as Bootstrap buttons with Font Awesome icons. To test, apply the patch and go to Administration -> MARC frameworks -> MARC structure. - In the list of tags for your selected MARC framework, the "Subfields," "Edit" and "Delete" items in the 'Actions' menu should look correct and work correctly. - Choose "Subfields" for any tag. In the list of subfields, the "Edit" and "Delete" buttons should look correct and work correctly. Created attachment 51876 [details] [review] Bug 16546 - Make edit and delete links styled buttons in MARC bibliographic framework administration This patch modifies two MARC framwork templates, styling some edit and delete links as Bootstrap buttons with Font Awesome icons. To test, apply the patch and go to Administration -> MARC frameworks -> MARC structure. - In the list of tags for your selected MARC framework, the "Subfields," "Edit" and "Delete" items in the 'Actions' menu should look correct and work correctly. - Choose "Subfields" for any tag. In the list of subfields, the "Edit" and "Delete" buttons should look correct and work correctly. Signed-off-by: Holger Meißner <h.meissner.82@web.de> Created attachment 51877 [details] [review] Bug 16546 - Make edit and delete links styled buttons in MARC bibliographic framework administration This patch modifies two MARC framwork templates, styling some edit and delete links as Bootstrap buttons with Font Awesome icons. To test, apply the patch and go to Administration -> MARC frameworks -> MARC structure. - In the list of tags for your selected MARC framework, the "Subfields," "Edit" and "Delete" items in the 'Actions' menu should look correct and work correctly. - Choose "Subfields" for any tag. In the list of subfields, the "Edit" and "Delete" buttons should look correct and work correctly. Signed-off-by: Holger Meißner <h.meissner.82@web.de> Created attachment 51878 [details] [review] Bug 16546 - Make edit and delete links styled buttons in MARC bibliographic framework administration This patch modifies two MARC framwork templates, styling some edit and delete links as Bootstrap buttons with Font Awesome icons. To test, apply the patch and go to Administration -> MARC frameworks -> MARC structure. - In the list of tags for your selected MARC framework, the "Subfields," "Edit" and "Delete" items in the 'Actions' menu should look correct and work correctly. - Choose "Subfields" for any tag. In the list of subfields, the "Edit" and "Delete" buttons should look correct and work correctly. Signed-off-by: Holger Meißner <h.meissner.82@web.de> Tested as well, works as expected. Holger, did you forget to switch the status to "Signed-off"? Created attachment 51948 [details] [review] Bug 16546 - Make edit and delete links styled buttons in MARC bibliographic framework administration This patch modifies two MARC framwork templates, styling some edit and delete links as Bootstrap buttons with Font Awesome icons. To test, apply the patch and go to Administration -> MARC frameworks -> MARC structure. - In the list of tags for your selected MARC framework, the "Subfields," "Edit" and "Delete" items in the 'Actions' menu should look correct and work correctly. - Choose "Subfields" for any tag. In the list of subfields, the "Edit" and "Delete" buttons should look correct and work correctly. Signed-off-by: Holger Meißner <h.meissner.82@web.de> Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 51949 [details] [review] Bug 16546 - Make edit and delete links styled buttons in MARC bibliographic framework administration This patch modifies two MARC framwork templates, styling some edit and delete links as Bootstrap buttons with Font Awesome icons. To test, apply the patch and go to Administration -> MARC frameworks -> MARC structure. - In the list of tags for your selected MARC framework, the "Subfields," "Edit" and "Delete" items in the 'Actions' menu should look correct and work correctly. - Choose "Subfields" for any tag. In the list of subfields, the "Edit" and "Delete" buttons should look correct and work correctly. Signed-off-by: Holger Meißner <h.meissner.82@web.de> Signed-off-by: Marc Véron <veron@veron.ch> Signing off. Sorry for the duplicate upload, after uploading I got a 500 internal error from Bugzilla (Failed to attach patch to bug 16546, status 500), but patches were attached anyway. As I already said, it seems that 3 buttons could be displayed in the same column to avoid 1 click. Why did not join put Edit and Delete into the same column (/marc_subfields_structure.pl?tagfield=200&frameworkcode=)? |