Bug 16717

Summary: Remove hardcoded category from Holds.t
Product: Koha Reporter: Marcel de Rooy <m.de.rooy>
Component: Test SuiteAssignee: Marcel de Rooy <m.de.rooy>
Status: CLOSED FIXED QA Contact: Galen Charlton <gmcharlt>
Severity: minor    
Priority: P5 - low CC: f.demians, julian.maurice, kyle, veron
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 16717: Remove hardcoded category from Holds.t
Bug 16717: Remove hardcoded category from Holds.t
Bug 16717: Remove hardcoded category from Holds.t
Bug 16717: Improve variable naming

Description Marcel de Rooy 2016-06-13 07:53:59 UTC
This patch comes from report 16607. With a limited scope it needed its own report.
Comment 1 Marcel de Rooy 2016-06-13 07:56:25 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-06-13 08:19:08 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-06-14 10:20:47 UTC
Created attachment 52363 [details] [review]
Bug 16717: Remove hardcoded category from Holds.t

There is actually no need to use the hardcoded patron category S in
this test.

Test plan:
Run t/db_dependent/Holds.t.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Test passes OK
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jonathan Druart 2016-06-14 10:20:51 UTC
Created attachment 52364 [details] [review]
Bug 16717: Improve variable naming

$category was a categorycode, to help the readability it's better to
name it $categorycode or assign a Category to $category

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Kyle M Hall 2016-06-17 14:46:28 UTC
Pushed to master for Koha 16.11, thanks Marcel!
Comment 6 Frédéric Demians 2016-06-24 05:46:35 UTC
Pushed in 16.05. Will be in 16.05.01.
Comment 7 Julian Maurice 2016-07-01 07:05:17 UTC
Patches pushed to 3.22.x, will be in 3.22.9