| Summary: | Remove hardcoded category from Holds.t | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
| Component: | Test Suite | Assignee: | Marcel de Rooy <m.de.rooy> |
| Status: | CLOSED FIXED | QA Contact: | Galen Charlton <gmcharlt> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | f.demians, julian.maurice, kyle, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 16717: Remove hardcoded category from Holds.t
Bug 16717: Remove hardcoded category from Holds.t Bug 16717: Remove hardcoded category from Holds.t Bug 16717: Improve variable naming |
||
|
Description
Marcel de Rooy
2016-06-13 07:53:59 UTC
Created attachment 52301 [details] [review] Bug 16717: Remove hardcoded category from Holds.t There is actually no need to use the hardcoded patron category S in this test. Test plan: Run t/db_dependent/Holds.t. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 52304 [details] [review] Bug 16717: Remove hardcoded category from Holds.t There is actually no need to use the hardcoded patron category S in this test. Test plan: Run t/db_dependent/Holds.t. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Test passes OK Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 52363 [details] [review] Bug 16717: Remove hardcoded category from Holds.t There is actually no need to use the hardcoded patron category S in this test. Test plan: Run t/db_dependent/Holds.t. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Test passes OK Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 52364 [details] [review] Bug 16717: Improve variable naming $category was a categorycode, to help the readability it's better to name it $categorycode or assign a Category to $category Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for Koha 16.11, thanks Marcel! Pushed in 16.05. Will be in 16.05.01. Patches pushed to 3.22.x, will be in 3.22.9 |