Bug 16762

Summary: Record matching rules: Remove match check link removes too much
Product: Koha Reporter: Owen Leonard <oleonard>
Component: System AdministrationAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: frederic, gmcharlt, hector.hecaxmmx, julian.maurice, kyle
Version: master   
Hardware: All   
OS: All   
URL: /cgi-bin/koha/admin/matching-rules.pl?op=edit_matching_rule&matcher_id=X
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5006
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 16763    
Attachments: Bug 16762 - Record matching rules: Remove match check link removes too much
[SIGNED-OFF]Bug 16762: Record matching rules: Remove match check link removes too much
[SIGNED-OFF]Bug 16762: Record matching rules: Remove match check link removes too much
Bug 16762: Record matching rules: Remove match check link removes too much

Description Owen Leonard 2016-06-17 15:32:17 UTC
Caused by my patch for Bug 5006: In record matching rules, if you remove the last match check, the entire match check container is deleted, including the controls for adding a new match check.
Comment 1 Owen Leonard 2016-06-17 16:46:19 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2016-06-22 17:52:37 UTC Comment hidden (obsolete)
Comment 3 Héctor Eduardo Castro Avalos 2016-06-22 17:53:05 UTC Comment hidden (obsolete)
Comment 4 Kyle M Hall 2016-06-24 15:38:49 UTC
Created attachment 52815 [details] [review]
Bug 16762: Record matching rules: Remove match check link removes too much

My patch for Bug 5006 introduced a lot of markup changes to the record
matching rules template. I missed a change in one are though, which
caused a bug with the way the 'Remove match check' link works.

To reproduce:

- Go to Administration -> Record matching rules.
- Edit a matching rule which includes at least one match check.
- Click a 'Remove match check' link. The entire "Required match checks"
  block is removed.

To test, apply the patch and repeat the steps above. Clicking any
'Remove match check' link should remove only the corresponding rule.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 5 Kyle M Hall 2016-07-08 12:50:33 UTC
Pushed to master for 16.11, thanks Owen!
Comment 6 Frédéric Demians 2016-08-01 13:23:12 UTC
Pushed in 16.05. Will be in 16.05.02.
Comment 7 Julian Maurice 2016-08-16 14:21:50 UTC
Patch pushed to 3.22.x, will be in 3.22.10