Bug 16763 - Remove the use of "onclick" from record matching rules form
Summary: Remove the use of "onclick" from record matching rules form
Status: ASSIGNED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/admin/matching-rules.pl...
Keywords:
Depends on: 16762 24899
Blocks: 17858
  Show dependency treegraph
 
Reported: 2016-06-17 17:06 UTC by Owen Leonard
Modified: 2020-03-18 19:14 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16763 - Remove the use of "onclick" from record matching rules form (14.23 KB, patch)
2016-06-17 17:23 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF]Bug 16763: Remove the use of "onclick" from record matching rules form (14.28 KB, patch)
2016-06-30 19:32 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Screenshot of step 5 as described in Comment 4 (96.76 KB, image/png)
2016-08-15 16:53 UTC, Owen Leonard
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-06-17 17:06:03 UTC
There are many uses of "onclick" in the record matching rules edit form. These should be removed in favor of defining events in JavaScript.
Comment 1 Owen Leonard 2016-06-17 17:23:25 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2016-06-30 19:32:43 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-07-01 14:44:38 UTC
Owen, if you add a rule without match point and then edit it again to add one, clicking on "Add match point" won't display the form.
Comment 4 Owen Leonard 2016-08-05 14:28:56 UTC
(In reply to Jonathan Druart from comment #3)
> Owen, if you add a rule without match point and then edit it again to add
> one, clicking on "Add match point" won't display the form.

Is this what you're describing?

1. Click 'New record matching rule'
2. Fill in all the required fields at the top, but no match points or match checks.
3. Save the rule.
4. Edit the rule you just created.
5. Click the 'Add match point' link --> The Match point 2 form doesn't display?

Step 5 works correctly for me, so I'm not sure I understand the problem.
Comment 5 Jonathan Druart 2016-08-12 12:27:54 UTC
Owen,
So yes it is displayed, but at the bottom under the "match checks" block.
Actually the "match checks" block is contained into the "match points" block when there is no match points.
They are 2 different blocks when you add a new rule or edit a rule with match points.
Comment 6 Owen Leonard 2016-08-15 16:53:04 UTC
Created attachment 54487 [details]
Screenshot of step 5 as described in Comment 4

Here's what I see after step 5 as described in Comment 4. Is that what you're seeing?
Comment 7 Jonathan Druart 2018-09-14 19:22:36 UTC
can you rebase the patches?