Bug 17010

Summary: Canceling a hold awaiting pickup no longer alerts librarian about next hold
Product: Koha Reporter: Kyle M Hall <kyle>
Component: Hold requestsAssignee: Kyle M Hall <kyle>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: frederic, gmcharlt, julian.maurice, katrin.fischer, nick
Version: unspecified   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17150
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17335
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17337
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19685
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 17749    
Bug Blocks:    
Attachments: Bug 17010 - Canceling a hold that has been waiting too long from Holds Awaiting Pickup no longer alerts librarian about next hold
[SIGNED-OFF] Bug 17010 - Canceling a hold awaiting pickup no longer alerts librarian about next hold
Bug 17010 [Follow-up] Canceling a hold awaiting pickup no longer alerts librarian about next hold
y# Attachment to Bug 17010 - Canceling a hold awaiting pickup no longer alerts librarian about next hold
[PASSED QA] Bug 17010 - Canceling a hold awaiting pickup no longer alerts librarian about next hold
[PASSED QA] Bug 17010 [Follow-up] Canceling a hold awaiting pickup no longer alerts librarian about next hold
Bug 17010 FOLLOWUP fix typo

Description Kyle M Hall 2016-08-01 13:30:23 UTC
In previous versions of Koha, if a hold canceled from the "Holds over" tab had other holds on it, the librarian would be alerted with the message "This item is on hold for pick-up at your library" and directed to check it in to fill the next hold. This no longer happens.
Comment 1 Kyle M Hall 2016-08-01 14:25:56 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2016-08-09 17:02:24 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2016-08-09 17:02:36 UTC Comment hidden (obsolete)
Comment 4 Liz Rea 2016-09-09 02:47:20 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2016-09-10 08:16:49 UTC
Created attachment 55459 [details] [review]
[PASSED QA] Bug 17010 - Canceling a hold awaiting pickup no longer alerts librarian about next hold

In previous versions of Koha, if a hold canceled from the "Holds over" tab had other holds on it,
the librarian would be alerted with the message "This item is on hold for pick-up at your library"
and directed to check it in to fill the next hold. This no longer happens.

Test Plan:
1) Apply this patch
2) Find a hold that has been waiting too long
3) Cancel that hold via waitingreserves.pl
4) Note you get the message "This item is on hold for pick-up at your library"
5) Confirm the ok button redirects you to the correct tab

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer  <katrin.fischer@bsz-bw.de>
Comment 6 Katrin Fischer 2016-09-10 08:17:19 UTC
Created attachment 55460 [details] [review]
[PASSED QA] Bug 17010 [Follow-up] Canceling a hold awaiting pickup no longer alerts librarian about next hold

This patch makes a minor change to the markup to make the button in the
confirmation dialog conform to the appearance of similar buttons.

To test, follow the original test plan for this bug and verify that the
"OK" button in the dialog looks correct.

Signed-off-by: Liz Rea <liz@catalyst.net.nz>

Signed-off-by: Katrin Fischer  <katrin.fischer@bsz-bw.de>
Comment 7 Kyle M Hall 2016-09-15 13:35:40 UTC
Pushed to master for 16.11, thanks for the followup Owen!
Comment 8 Frédéric Demians 2016-09-15 14:59:58 UTC
Pushed in 16.05. Will be in 16.05.04.
Comment 9 Julian Maurice 2016-09-16 10:01:14 UTC
Pushed to 3.22.x, will be in 3.22.11
Comment 10 Nick Clemens 2016-12-08 19:43:25 UTC
Created attachment 58052 [details] [review]
Bug 17010 FOLLOWUP fix typo

waitingreserves.p#[% tab %]

should be

waitingreserves.pl#[% tab %]
Comment 11 Nick Clemens 2016-12-08 19:56:49 UTC
Comment on attachment 58052 [details] [review]
Bug 17010 FOLLOWUP fix typo

Moved followup to bug 17749