Description
Kyle M Hall
2016-08-01 13:30:23 UTC
Created attachment 53840 [details] [review] Bug 17010 - Canceling a hold that has been waiting too long from Holds Awaiting Pickup no longer alerts librarian about next hold In previous versions of Koha, if a hold canceled from the "Holds over" tab had other holds on it, the librarian would be alerted with the message "This item is on hold for pick-up at your library" and directed to check it in to fill the next hold. This no longer happens. Test Plan: 1) Apply this patch 2) Find a hold that has been waiting too long 3) Cancel that hold via waitingreserves.pl 4) Note you get the message "This item is on hold for pick-up at your library" 5) Confirm the ok button redirects you to the correct tab Created attachment 54241 [details] [review] [SIGNED-OFF] Bug 17010 - Canceling a hold awaiting pickup no longer alerts librarian about next hold In previous versions of Koha, if a hold canceled from the "Holds over" tab had other holds on it, the librarian would be alerted with the message "This item is on hold for pick-up at your library" and directed to check it in to fill the next hold. This no longer happens. Test Plan: 1) Apply this patch 2) Find a hold that has been waiting too long 3) Cancel that hold via waitingreserves.pl 4) Note you get the message "This item is on hold for pick-up at your library" 5) Confirm the ok button redirects you to the correct tab Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 54242 [details] [review] Bug 17010 [Follow-up] Canceling a hold awaiting pickup no longer alerts librarian about next hold This patch makes a minor change to the markup to make the button in the confirmation dialog conform to the appearance of similar buttons. To test, follow the original test plan for this bug and verify that the "OK" button in the dialog looks correct. Created attachment 55387 [details] [review] y# Attachment to Bug 17010 - Canceling a hold awaiting pickup no longer alerts librarian about next hold Bug 17010 [Follow-up] Canceling a hold awaiting pickup no longer alerts librarian about next hold This patch makes a minor change to the markup to make the button in the confirmation dialog conform to the appearance of similar buttons. To test, follow the original test plan for this bug and verify that the "OK" button in the dialog looks correct. Signed-off-by: Liz Rea <liz@catalyst.net.nz> Created attachment 55459 [details] [review] [PASSED QA] Bug 17010 - Canceling a hold awaiting pickup no longer alerts librarian about next hold In previous versions of Koha, if a hold canceled from the "Holds over" tab had other holds on it, the librarian would be alerted with the message "This item is on hold for pick-up at your library" and directed to check it in to fill the next hold. This no longer happens. Test Plan: 1) Apply this patch 2) Find a hold that has been waiting too long 3) Cancel that hold via waitingreserves.pl 4) Note you get the message "This item is on hold for pick-up at your library" 5) Confirm the ok button redirects you to the correct tab Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Created attachment 55460 [details] [review] [PASSED QA] Bug 17010 [Follow-up] Canceling a hold awaiting pickup no longer alerts librarian about next hold This patch makes a minor change to the markup to make the button in the confirmation dialog conform to the appearance of similar buttons. To test, follow the original test plan for this bug and verify that the "OK" button in the dialog looks correct. Signed-off-by: Liz Rea <liz@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Pushed to master for 16.11, thanks for the followup Owen! Pushed in 16.05. Will be in 16.05.04. Pushed to 3.22.x, will be in 3.22.11 Created attachment 58052 [details] [review] Bug 17010 FOLLOWUP fix typo waitingreserves.p#[% tab %] should be waitingreserves.pl#[% tab %] Comment on attachment 58052 [details] [review] Bug 17010 FOLLOWUP fix typo Moved followup to bug 17749 |